Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(motor-control): Reimplement motor driver chip errors as poller #811

Merged
merged 13 commits into from
Oct 25, 2024

Conversation

ryanthecoder
Copy link
Contributor

@ryanthecoder ryanthecoder commented Oct 24, 2024

The additional interrupts were causing too much of a slowdown on some nodes so this re-implements this as a polling based detection system instead of a interrupt based one.
RQA-3405

@ryanthecoder ryanthecoder force-pushed the Reimplement-motor-driver-chip-errors branch from 3d0f69c to 6fea861 Compare October 24, 2024 19:23
@ryanthecoder ryanthecoder marked this pull request as ready for review October 24, 2024 19:56
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots easier, nice!

Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

negative diff, lets go!

@ryanthecoder ryanthecoder merged commit 744fb80 into main Oct 25, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants