Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flex-stacker): add estop #482

Merged
merged 3 commits into from
Nov 21, 2024
Merged

feat(flex-stacker): add estop #482

merged 3 commits into from
Nov 21, 2024

Conversation

ahiuchingau
Copy link
Contributor

This PR lets us read the estop state from Gcode and sets it up as an interrupt that notifies the motor task in the same way as the driver stall diagnostic pin.

@ahiuchingau ahiuchingau requested review from vegano1 and sfoster1 and removed request for vegano1 November 20, 2024 21:13
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We'll have to be very careful with our python-side comms handling now that this can send its own messages

Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, left small comment.

@ahiuchingau ahiuchingau merged commit 393bae8 into edge Nov 21, 2024
6 of 7 checks passed
@ahiuchingau ahiuchingau deleted the EXEC-954-e-stop branch November 21, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants