refactor!:deprecate ntp code path

[JarbasAl]

Summary by CodeRabbit

• New Features

  • Streamlined functionality by removing NTP synchronization support.

• Bug Fixes

  • Eliminated redundant event listener for NTP synchronization.

• Chores

  • Minor adjustments including reordering of import statements and adding a TODO comment.

[coderabbitai]

Walkthrough

The changes involve the removal of the handle_ntp_sync_request method and the associated event listener for NTP synchronization from the SystemEventsValidator class in the ovos_PHAL_plugin_system module. This indicates that the plugin will no longer support NTP synchronization functionality. Minor adjustments include reordering import statements and adding a TODO comment in another method.

Changes

Files	Change Summary
ovos_PHAL_plugin_system/__init__.py	Removed handle_ntp_sync_request method and event listener for system.ntp.sync. Reordered imports and added a TODO comment.

Poem

In the burrow where bunnies play,
The clock ticks in its own sweet way.
No more syncing with the stars above,
Just hopping along, in a world we love.
With every leap, our time is ours,
In fields of joy, beneath the stars! 🌟🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

ovos_PHAL_plugin_system/__init__.py (1)

Line range hint 278-286: Refactor the service restart logic.

The code for restarting the mycroft or ovos service needs to be refactored for better readability, maintainability, and error handling.

Consider the following improvements:

• Handle specific exceptions instead of using a bare except block to make it easier to identify the root cause of issues.
• Provide feedback to the user if the service restart fails, either through a log message or by emitting a message on the bus.
• Extract the service restart logic into a separate method for better readability and maintainability.

For example:

def restart_mycroft_service(self):
    try:
        restart_service(self.core_service_name, sudo=False, user=True)
    except subprocess.CalledProcessError as e:
        LOG.warning(f"Failed to restart service as user: {e}")
        try:
            restart_service(self.core_service_name, sudo=True, user=False)
        except subprocess.CalledProcessError as e:
            LOG.error(f"Failed to restart service as root: {e}")
            self.bus.emit(Message("system.mycroft.service.restart.failed"))
            return
    self.bus.emit(Message("system.mycroft.service.restart.succeeded"))

Tools

Ruff

281-281: Do not use bare except

(E722)

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 720462e and 4de3bb6.

Files selected for processing (1)

• ovos_PHAL_plugin_system/init.py (3 hunks)

Additional comments not posted (4)

ovos_PHAL_plugin_system/__init__.py (4)

9-10: LGTM!

The import statement is valid and does not introduce any issues.

---

18-21: LGTM!

The import statements are valid and do not introduce any issues.

---

312-315: LGTM!

The SystemEventsAdminValidator class definition is valid and does not introduce any issues. The validate method is overridden to always return True when running as root, and the log message provides useful information for debugging purposes.

---

Line range hint 319-320: LGTM!

The SystemEventsAdminPlugin class definition is valid and does not introduce any issues. The class inherits from both AdminPlugin and SystemEventsPlugin, which provides access to the methods and attributes of both classes. The validator attribute is set to SystemEventsAdminValidator, ensuring that the plugin is validated using the appropriate validate method when running as root.