-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speaking time edit and overtime #3160
Speaking time edit and overtime #3160
Conversation
Apart from the remaining todos this LGTM. You could also cleanup the comments with the descriptions of the functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overhang time can be activated if a contribution is only paused, should only be possible if the contribution is stopped
After overhang time was distributed once the following Error is thrown in the console
speaking-times.component.ts:62 ERROR TypeError: Cannot read properties of null (reading 'getTitle')
the displayed speaking times in the LoS and in the Speaking times Card are different.
the displayed time in speaking times is correct, please adjust the speaking times in the LoS
The addition of the overhang time is only enabled, if all speakers of a speakingTime are not "active" and not "paused". I couldn't reproduce the type error. @Elblinator said, with clean data, the error no longer occurs. The third cr is still open. |
The additional time is already in the remaining time added.
Update the los content display. Now speaking times and los display the same times, even if additional time is there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overhang time should only be added onto the structure levels which are represented in the LoS
If you have structure levels A, B and C and only participants from A and B are on the LoS (so far) overhang time should only be added onto Level A and B
Must be fixed in the backend -> OpenSlides/openslides-backend#2140 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the fix needs to be in the backend, then I approve this PR
It can also be mergeed after to code review is through imo
...pp/site/pages/meetings/pages/autopilot/components/speaking-times/speaking-times.component.ts
Outdated
Show resolved
Hide resolved
...pp/site/pages/meetings/pages/autopilot/components/speaking-times/speaking-times.component.ts
Outdated
Show resolved
Hide resolved
773f58c
into
OpenSlides:feature/los-extension
First draft version of the edit and overhang times parts of the speaking times component.
@bastianjoel Pls have a look at it.