Deleted participants stay present in meeting #2730
Conversation
| def check_meeting_and_users( | ||
| self, instance: dict[str, Any], user_fqid: FullQualifiedId |
There was a problem hiding this comment.
As far as I looked at the source code check_meeting_and_users is called every time if a user action with the mixin is called. I think, you want to call a presence cleaning only if the user is removed from an meeting or deleted.
There was a problem hiding this comment.
I've found that at the same condition the 'ConditionalSpeakerCascadeMixin' is executing its 'update_instance'. So I moved it there. I propose to rename this mixin to 'ConditionalMeetingUserCascadeMixin'
| "meeting_id": meeting_id, | ||
| "present": False, | ||
| } |
There was a problem hiding this comment.
Does this handle the case, if a user is deleted and presence in two meetings?
There was a problem hiding this comment.
Now in its new place it does. :)
| This migration adds the user_id "-1" to all existing action_workers. | ||
| This is the number usually used for calls using the internal route. |
There was a problem hiding this comment.
user_id -1 is not an Id and will lead to errors. Why use such an id?
There was a problem hiding this comment.
Wrote the actual description.
| meetings = self.reader.get_all( | ||
| "meeting", ["group_ids", "present_user_ids", "meeting_user_ids"] | ||
| ) | ||
| users = self.reader.get_all( | ||
| "user", ["is_present_in_meeting_ids", "meeting_user_ids"] | ||
| ) |
There was a problem hiding this comment.
Ui, that is a large operation, getting 1000+ meetings and 10000+ users in worse case. Use get_all with cautious
and use filter, etc instead.
There was a problem hiding this comment.
I thought about this but I couldn't think of a solution, because I have to compare in both directions if the presence relation between the meeting and user is corrupted. If only one way was necessary I could at least filter for all the users that are present in meetings.
There was a problem hiding this comment.
Due to refactoring this does not exist anymore. Now I'm using one filter for the meeting users and get_many for meeting and users.
| "user", ["is_present_in_meeting_ids", "meeting_user_ids"] | ||
| ) | ||
|
|
||
| def helper() -> None: |
There was a problem hiding this comment.
Due to refactoring this function does not exist anymore.
|
|
||
| def helper() -> None: | ||
| if not ( | ||
| (meeting_user_ids := user.get("meeting_user_ids", [])) |
There was a problem hiding this comment.
Where does helper get his user from?
There was a problem hiding this comment.
Added arguments. Before the nested function would use all local variables in the enclosing scope.
There was a problem hiding this comment.
Due to refactoring this function does not exist anymore.
| for lookup, cross_lookup, what_collection, field in [ | ||
| (meetings, present_users_per_meeting, "meeting", "present_user_ids"), | ||
| (users, meetings_per_present_user, "user", "is_present_in_meeting_ids"), | ||
| ] | ||
| for what_id, which_ids in cross_lookup.items() |
There was a problem hiding this comment.
Better to use two loops here. This code no one understands, is bogus.
Closes #2729