I1927 Accelerate poll.stop by reducing locked fields #1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-peschke
added
high
enhancement
r-peschke
force-pushed
the
I1927_try_by_reducing_unused_lock_fields
branch
from
4253127
to
3d23521
Compare
r-peschke
added
the
waiting
|
This solution is a little too specific and hacky for this situation, I think. But the general idea is good. How about we mark each field that will never change its value as The "cleaner" solution in some sense would of course be to not even request those fields to be locked, but that would be very cumbersome to implement. |
|
Opened #2172 to implement a cleaner solution of this. Closing this PR for now. |
r-peschke
removed
the
waiting
|
approximately 50% acceleration reported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unnecessary lock_fields for memory and performance issues. For not being punished with performance penalty and error prune changes in manual optimization of database calls, the caching ability is still used with locking calls.
Waiting for approval and decision, if this change should be taken to main branch or only be used for special cases