Topic json upload rework #1914
Merged
Topic json upload rework #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reiterl
added
the
enhancement
r-peschke
force-pushed
the
topic-json-upload-rework
branch
from
bfcaaf8
to
3a3d197
Compare
r-peschke
requested review from
jsangmeister
and removed request for
r-peschke
2 tasks
jsangmeister
previously requested changes
Sep 27, 2023
Comment on lines
61
to
69
| agenda_item = { | ||
| field[7:]: value | ||
| for field in self.agenda_item_fields | ||
| if (value := entry.pop(field, None)) is not None | ||
| } | ||
| if agenda_item: | ||
| agenda_item["id"] = self.topic_lookup.get_field_by_name( | ||
| entry["title"], "agenda_item_id" | ||
| ) | ||
| update_agenda_item_payload.append(agenda_item) |
There was a problem hiding this comment.
Merge this with the code here:
Also, magic numbers (like the 7 here) are almost never a good idea
| @@ -195,3 +158,77 @@ def test_json_uplad_permission(self) -> None: | |||
| {"data": [{"title": "test"}], "meeting_id": 1}, | |||
| Permissions.AgendaItem.CAN_MANAGE, | |||
| ) | |||
|
|
|||
|
|
|||
| class TopicJsonUploadForUseInImport(BaseActionTestCase): | |||
There was a problem hiding this comment.
Same comment here as in the account import: Move these to a separate file
There was a problem hiding this comment.
see comment in account import
r-peschke
force-pushed
the
topic-json-upload-rework
branch
from
bb5a57a
to
b82ac49
Compare
r-peschke
force-pushed
the
topic-json-upload-rework
branch
from
b82ac49
to
c9687ad
Compare
…topic and account import
It uses now the general Lookup class with a small modification. The lookup is per meeting.
The JsonUploadMixin handles the type checks.
The topic has a required agenda item. If agenda_* fields are given in the data, this agenda item is updated too. Topic import can only update text, because title is needed for identification.
r-peschke
force-pushed
the
topic-json-upload-rework
branch
from
c9687ad
to
49a817f
Compare
|
After discussion today it was decided to merge the PR like it is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased on #1912.
Needs datastore with action_worker route also for collection import_preview now on datastore PR259 Open action_worker route for import_preview