-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electrification style #24
Conversation
The dashing you showed in the preview images is not in the style anymore, see also #14. |
So what is required for merge? Change the style of railway lines under construction? |
* Add missing fields in SQL queries and views * Add missing functions * Remove maxspeed stuff
Before: 909 kB 57 seconds, afterwards 724 kB 15 seconds
This requires preprocessing with SQL because otherwise we would end up with transpilation times of more than 4 minutes and 6.5 MB XML instead of 737 kB.
* fix bugs in SQL queries * equal minimal zoom levels for lines and labels * fix SQL function
This makes lines without electrification but one in future (proposed/construction) to appea as colored dashed lines on top of a black line.
An additional style for the fill layers is not going to work reliably. Changes to order of the .mss files which seem to have to same meaning from a style author point of view lead to different results in XML and make authors become crazy. Splitting of into a separate layer is a bit more difficult because we need compositing operations to achieve the same effect but it makes working on the style easier.
05197b5
to
20ce02e
Compare
This applies the changes from #34 to the electrification style.
This was a leftover of copy-pasting.
Please mind that the images shown in the comments above do not reflect the changes I made in later commits. However, the tiles at https://tiles.openrailwaymap.org/#osm.org/9/53.304495/8.340068&overlays=electrification are up to date. |
With the current tiles, I see the following problems:
|
Issues:
|
@c933103 wrote:
I admit that I have never thought about ways with
On the other hand, we have 753,912 ways with The MapCSS style does not show a
Yes, but this is out of scope for this pull request. The pull request aims to rebuild the MapCSS map style as that style is.
There are not differences in rendering. Even their edit history does not explain any differences back then when you wrote your comment. |
When you look on the other 1.5kV track at the upper right of your image, there are some segments that are rendered in gray. I suspect there are actually 2 tracks close to each other, one of them without electrification tagging. |
This commit adds coloured dashing for railway=construction without usage=* and service=*.
On zoom < 9, electrification under construction and proposed electrification is rendered like electrified=no.
I fixed this. Zoom 8: Zoom 9:
The bug became visible because the track has neither |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's start with what we have and improve incrementally, otherwise this will take another year or more.
This is the current state of work on the electrification style.
Rastatt at zoom levels 11, 13 and 16:
Wendlingen (zoom level 11):
Europe at zoom level 4 (The database used for this test contained data of Europe only):
Sande (zoom level 8 and 12):
Karlsruhe (zoom level 17):
Power off section between Delitzsch u Bf and Rackwitz (bei Leipzig) at zoom level 17: