only set randompasswd in graphics template if it's true

[nilsding]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for PR followers and do not help prioritize the request

Description

older OpenNebula versions (like 5.12) interpret the RANDOM_PASSWORD as truthy if its value is not empty and therefore try to generate a password, which when using VNC will be too long and not truncated due to another bug that's already been fixed in the latest release.

(yes, I know, we should really update our setup ...)

References

New or Affected Resource(s)

• opennebula_template

Checklist

• I have created an issue and I have mentioned it in References
• My code follows the style guidelines of this project (use go fmt)
• My changes generate no new warnings or errors
• I have updated the unit tests and they pass succesfuly
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation (if needed)
• I have updated the changelog file

[frousselet]

Hello @nilsding,

Unfortunately we don't support OpenNebula bellow 5.12.
I would suggest you to fork the provider while you are on a version bellow 5.12 and compile your version including your changes on your side.

[nilsding]

Hi @frousselet, the readme mentions that OpenNebula ~> 5.12 is still supported 🤔

But the bug fixed by this PR also affects at least >= 6.0, < 6.1.80, as the random_password handling was changed around that time in OpenNebula/one@0edcc7a

[frousselet]

My bad, I misread 😬
I reopen it

[github-actions]

This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days.

[akurz]

Hi @frousselet, looks like this PR was "forgotten" - would you be so kind and reopen it, thx!

[treywelsh]

hi, sorry for the late reply, instead of modifying the default behavior for all the releases, could you check the version instead and add an if - else to handle your specific case ?

Here's an example: https://github.com/OpenNebula/terraform-provider-opennebula/blob/master/opennebula/resource_opennebula_marketplace_app.go#L180

Then rebase your PR, add a line in the CHANGELOG and I'll review it

[github-actions]

This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days.

[treywelsh]

I remove the stale label to let it open some more days as it took me a bit of time to review it

[dgarcia18]

Tested for OpenNebula versions >5.12. For these versions, setting RANDOM_PASSWD = "NO" is completely equivalent to not setting it. LGTM, merging.