Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyInstrument Profiling #9083

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

rasswanth-s
Copy link
Collaborator

Description

The PR aims to add pyinstrument profiling support to in-memory workers.
The profiling functionality can be useful for

  • In-memory worker - uvicorn
  • In- memory worker - without uvicorn

This can be triggered as simply by enabling a flag in orchestra profile=True

For K8s tracing, we could do once OTel PR is merged.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

Add an example notebook for the same

Checklist

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@yashgorana
Copy link
Contributor

@rasswanth-s what is the state of this PR? do we need it this week's release?

@rasswanth-s
Copy link
Collaborator Author

rasswanth-s commented Sep 27, 2024

@yashgorana , we do not need it for this week's release, but this is a useful feature for profiling our stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants