Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore libsuffix support in pkg-config file #4982

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

svillemot
Copy link
Contributor

It had been mistakenly removed in 9ef10ff.

It had been mistakenly removed in 9ef10ff.
@martin-frbg
Copy link
Collaborator

Ugh, not again. But I don't think your fix is entirely correct either, the libsuffix is the same as the symbolsuffix so would come before the libnamesuffix (?)

@svillemot
Copy link
Contributor Author

libsuffix is empty for 32-bit indexing and equal to 64 for 64-bit indexing. It’s used for the Debian packages.

@svillemot
Copy link
Contributor Author

Also note that I did the same as in cmake/openblas.pc.in.

@martin-frbg
Copy link
Collaborator

then there is probably more chaos in the naming. cmake builds differ from gmake "historically" by automatically setting SYMBOLSUFFIX=64 (which carries over into LIBSUFFIX=64) for 64bit indexing, but in principle that SYMBOLSUFFIX can be overriden by the user in either case. And any other suffix on the library name (such as _numpy, _scipy or whatever else has been used in the past) would need to come after the usually-numerical-when-present SYMBOLSUFFIX I think

@svillemot
Copy link
Contributor Author

Ok. I don’t know the purpose of libnamesuffix and I don’t use it, so I don’t have a strong opinion. Please implement whatever solutions looks correct to you. From the perspective of Debian, it’s ok as long as the 64 suffix appears in the generated pkg-config file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants