Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test results to the release builds table #3336

Merged
merged 8 commits into from
Aug 24, 2023
Merged

Add test results to the release builds table #3336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2d48af9
Add test results to releases table
steven1046 Aug 15, 2023
427e26c
Reduce test column to 1 width
steven1046 Aug 16, 2023
fb92e5a
Style columns better
steven1046 Aug 16, 2023
79d4ddf
Move tests to only one per release
steven1046 Aug 17, 2023
1269dd7
Update styling
steven1046 Aug 17, 2023
9cc7871
Change column order
steven1046 Aug 23, 2023
4daf255
Move test results under release blog and indent with a bullet
steven1046 Aug 24, 2023
a052dd0
Cleanup
steven1046 Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/main/content/_assets/css/openliberty.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,13 +140,19 @@ a {
font-size: 20px;
}

.release_table_body tr td a.blog_release_notes {
.release_table_body tr td a.version_sublink {
display: block;
font-weight: 400;

&::before {
content: "•";
font-size: 16px;
margin-right: 5px;
}
}

.release_table_body tr td a.blog_release_notes,
.release_table_body tr td a.blog_release_notes:focus {
.release_table_body tr td a.version_sublink,
.release_table_body tr td a.version_sublink:focus {
color: #5E6B8D;
}

Expand All @@ -155,7 +161,7 @@ a {
color: #CC4D19;
}

.release_table_body tr td a.blog_release_notes:hover,
.release_table_body tr td a.version_sublink:hover,
.orange_link_light_background:hover {
transition: all .2s;
}
Expand All @@ -164,7 +170,7 @@ a {
color: #F4914D;
}

.release_table_body tr td a.blog_release_notes:hover {
.release_table_body tr td a.version_sublink:hover {
color: #8595BE;
}

Expand Down
20 changes: 12 additions & 8 deletions src/main/content/_assets/js/builds.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ function render_builds(builds, parent) {
for (var i = 0; i < max - num_packages; i++) {
parent.append('<tr></tr>');
}
}
}

var version_column = $(
'<td headers="' +
Expand All @@ -269,7 +269,12 @@ function render_builds(builds, parent) {
num_packages +
'">' +
build.version +
(releaseBuild.releasePostLink ? '<a class="blog_release_notes" href="'+baseURL+'/blog/'+releaseBuild.releasePostLink+'">'+release_blog+'</a>' : '') +
(releaseBuild.releasePostLink ? '<a class="version_sublink" href="'+baseURL+'/blog/'+releaseBuild.releasePostLink+'">'+release_blog+'</a>' : '') +
(releaseBuild.tests_log ?
'<a class="version_sublink" ' +
'href="'+releaseBuild.tests_log + '" ' +
'title="' + releaseBuild.test_passed + '/' + releaseBuild.total_tests + ' tests passing"' +
'>Test results</a>' : '') +
'</td>'
);

Expand Down Expand Up @@ -314,7 +319,7 @@ function render_builds(builds, parent) {
// Optional sig file download button
(sig_href ? '<a href="'+pem_href+'" class="'+analytics_class_name +'" rel="noopener">' + download_arrow +'PEM</a>' : '' ) +
'</td>'
);
);

if (k === 0) {
row.append(version_column); // add version column for first item in package_locations
Expand Down Expand Up @@ -412,13 +417,12 @@ function render_builds(builds, parent) {
tableID +
'_package">All GA Features</td>';
}

row.append(package_column);
row.append(download_column);
row.append(download_column);
row.append(verification_column);
if (k === 0) {
// Only add the PEM button to the row with Version
row.append(verification_column2);
row.append(verification_column2);
}

// checking if version is from the last two years before adding to table
Expand Down Expand Up @@ -468,7 +472,7 @@ function render_builds(builds, parent) {
num_beta_packages +
'">' +
build.version +
(betaBuild.betaPostLink ? '<a class="blog_release_notes" href="'+baseURL+'/blog/'+betaBuild.betaPostLink+'">'+release_blog+'</a>' : '') +
(betaBuild.betaPostLink ? '<a class="version_sublink" href="'+baseURL+'/blog/'+betaBuild.betaPostLink+'">'+release_blog+'</a>' : '') +
'</td>'
);

Expand Down Expand Up @@ -643,7 +647,7 @@ function highlightAlternateRows() {

// 1. Look for all the release Version rows and apply the styling to every other version row
$("#runtime_releases_table_container .release_table_body tr").filter(function() {
return $(this).children().length === total_releases_columns;
return $(this).children().length === total_releases_columns;
}).filter(':even').addClass('highlight_alternate_rows');

// 2. Look for all the beta Version rows and apply the styling to every other version row
Expand Down
2 changes: 1 addition & 1 deletion src/main/content/start.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ <h2 id="downloads-pkg" class="section_title">{% t start.download_package %}</h2>
<tr>
<th id="runtime_releases_version" class="version_column"><a href="" data-key="version" data-descending="true" class="functional_link sort_link">{% t start.download_package_section.table_header.version %}</a></th>
<th id="runtime_releases_package" class="package_name_column">{% t start.download_package_section.table_header.package %}</th>
<th id="runtime_releases_download" class="download_button_column">{% t start.download_package_section.table_header.download %}</th>
<th id="runtime_releases_download" class="download_button_column">{% t start.download_package_section.table_header.download %}</th>
<th id="runtime_releases_verification" class="download_button_column" colspan="2">{% t start.download_package_section.table_header.verification %}</th>
</tr>
</thead>
Expand Down
Loading