-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Open Liberty APIs/SPIs to the SEO on docs #3323
Conversation
Line under tabs in /start is wider #3263
@chirp1, can you please review the wording change for SEO to include Open Liberty APIs/SPIs? Since Open Liberty are the only SPIs on the website, i added API to each of the other kind of javadocs in the sentence to show only Open Liberty have APIs and SPIs. Maybe we could make it a new sentence if it's too long. Old sentence: New sentence: |
@dmuelle @ramkumar-k-9286 Hi! Since you are working on the API/SPI landing pages, would you review for Steven? Thanks! |
Hi Steven- where does this text show up? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ID review- minor edits for clarity and sentence length
@@ -8,7 +8,7 @@ | |||
{{else if page.attributes.description }} | |||
<meta name="description" content="{{page.attributes.description}}"> | |||
{{ else }} | |||
<meta name="description" content="Open Liberty documentation and reference materials for developers to build applications and for administrators and operation teams to manage DevOps and deploy workloads to clouds using open cloud-native Java. Covers Open Liberty basics, development, security, deployment, and operations topics, as well as Javadoc for Jakarta EE, MicroProfile and Java EE APIs."> | |||
<meta name="description" content="Open Liberty documentation and reference materials for developers to build applications and for administrators and operation teams to manage DevOps and deploy workloads to clouds using open cloud-native Java. Covers Open Liberty basics, development, security, deployment, and operations topics, as well as Javadoc for Jakarta EE APIs, MicroProfile APIs, Java EE APIs, and Open Liberty APIs/SPIs."> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<meta name="description" content="Open Liberty documentation and reference materials for developers to build applications and for administrators and operation teams to manage DevOps and deploy workloads to clouds using open cloud-native Java. Covers Open Liberty basics, development, security, deployment, and operations topics, as well as Javadoc for Jakarta EE APIs, MicroProfile APIs, Java EE APIs, and Open Liberty APIs/SPIs."> | |
<meta name="description" content="Open Liberty documentation and reference materials for developers to build applications and for administrators and operation teams to manage DevOps and deploy workloads to clouds by using open cloud-native Java. This content covers Open Liberty basics, development, security, deployment, and operations topics. It also includes Javadoc for Jakarta EE APIs, MicroProfile APIs, Java EE APIs, and Open Liberty APIs and SPIs."> |
@@ -23,7 +23,7 @@ | |||
{{else if page.attributes.description }} | |||
<meta name="twitter:description" content="{{ page.attributes.description }}" /> | |||
{{ else }} | |||
<meta name="twitter:description" content="Open Liberty documentation and reference materials for developers to build applications and for administrators and operation teams to manage DevOps and deploy workloads to clouds using open cloud-native Java. Covers Open Liberty basics, development, security, deployment, and operations topics, as well as Javadoc for Jakarta EE, MicroProfile and Java EE APIs." /> | |||
<meta name="twitter:description" content="Open Liberty documentation and reference materials for developers to build applications and for administrators and operation teams to manage DevOps and deploy workloads to clouds using open cloud-native Java. Covers Open Liberty basics, development, security, deployment, and operations topics, as well as Javadoc for Jakarta EE APIs, MicroProfile APIs, Java EE APIs, and Open Liberty APIs/SPIs." /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<meta name="twitter:description" content="Open Liberty documentation and reference materials for developers to build applications and for administrators and operation teams to manage DevOps and deploy workloads to clouds using open cloud-native Java. Covers Open Liberty basics, development, security, deployment, and operations topics, as well as Javadoc for Jakarta EE APIs, MicroProfile APIs, Java EE APIs, and Open Liberty APIs/SPIs." /> | |
<meta name="description" content="Open Liberty documentation and reference materials for developers to build applications and for administrators and operation teams to manage DevOps and deploy workloads to clouds by using open cloud-native Java. This content covers Open Liberty basics, development, security, deployment, and operations topics. It also includes Javadoc for Jakarta EE APIs, MicroProfile APIs, Java EE APIs, and Open Liberty APIs and SPIs."> |
@@ -39,7 +39,7 @@ | |||
{{else if page.attributes.description }} | |||
<meta property="og:description" content="{{ page.attributes.description }}" /> | |||
{{ else }} | |||
<meta property="og:description" content="Open Liberty documentation and reference materials for developers to build applications and for administrators and operation teams to manage DevOps and deploy workloads to clouds using open cloud-native Java. Covers Open Liberty basics, development, security, deployment, and operations topics, as well as Javadoc for Jakarta EE, MicroProfile and Java EE APIs." /> | |||
<meta property="og:description" content="Open Liberty documentation and reference materials for developers to build applications and for administrators and operation teams to manage DevOps and deploy workloads to clouds using open cloud-native Java. Covers Open Liberty basics, development, security, deployment, and operations topics, as well as Javadoc for Jakarta EE APIs, MicroProfile APIs, Java EE APIs, and Open Liberty APIs/SPIs." /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<meta property="og:description" content="Open Liberty documentation and reference materials for developers to build applications and for administrators and operation teams to manage DevOps and deploy workloads to clouds using open cloud-native Java. Covers Open Liberty basics, development, security, deployment, and operations topics, as well as Javadoc for Jakarta EE APIs, MicroProfile APIs, Java EE APIs, and Open Liberty APIs/SPIs." /> | |
<meta property="og:description" content="Open Liberty documentation and reference materials for developers to build applications and for administrators and operation teams to manage DevOps and deploy workloads to clouds by using open cloud-native Java. This content covers Open Liberty basics, development, security, deployment, and operations topics. It also includes Javadoc for Jakarta EE APIs, MicroProfile APIs, Java EE APIs, and Open Liberty APIs and SPIs."> |
When people see links to our docs on Google and Twitter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
What was changed and why?
Added Open Liberty APIs/SPIs to the SEO for docs.
Fixes #3293
Tested using browser: