fix features-bom issue #1847
Open
fix features-bom issue #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherylking
previously approved these changes
Nov 21, 2024
|
fyi...I think there are two tests that may fail because of this change?
|
|
For issue #1819 |
jjiwooLim
force-pushed
the
featuresbom
branch
from
f9dead0
to
d6c2fa2
Compare
|
Updated tests to use |
cherylking
reviewed
Nov 23, 2024
| <version>1.0</version> | ||
| <type>pom</type> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
Does this mean if they have more than one user feature, they will not be able to configure it because they would both need a features-bom artifact in Maven? If so, that seems like an unreasonable restriction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only accept
features-bomartifactID to prepare and install user features.