Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created blog file cloudant-with-open-liberty.adoc #4160

Open
wants to merge 7 commits into
base: staging
Choose a base branch
from
Open

Created blog file cloudant-with-open-liberty.adoc #4160

wants to merge 7 commits into from

Conversation

revijay
Copy link

@revijay revijay commented Nov 24, 2024

Created blog file cloudant-with-open-liberty.adoc
Issue #4152.

Link to the blog in draft site : https://blogs-draft-openlibertyio.mqj6zf7jocq.us-south.codeengine.appdomain.cloud/blog/2024/11/25/cloudant-with-open-liberty.html

mswatosh
mswatosh requested changes Nov 25, 2024
View reviewed changes
Copy link
Member

@mswatosh mswatosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements, just a few minor corrections.

@revijay
Copy link
Author

revijay commented Nov 26, 2024

@mswatosh, thanks for the review. I have incorporated review comments. Please have a look

mswatosh
mswatosh previously approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@mswatosh mswatosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review looks good 👍

GraceJansen
GraceJansen previously approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@GraceJansen GraceJansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding in the intro and summary sections I requested. They read well and I think this post is now ready for publishing. Thanks for your work on this.

mswatosh
mswatosh requested changes Nov 27, 2024
View reviewed changes
Copy link
Member

@mswatosh mswatosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things I noticed in the new additions. The IAM section is a great addition

@revijay
Copy link
Author

revijay commented Nov 27, 2024

Thanks @mswatosh for your detailed review. I made the changes which you suggested.

mswatosh
mswatosh approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@mswatosh mswatosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I missed some unnecessary parameters in the ibm cloud url earlier, so I added a commit to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswatosh mswatosh mswatosh approved these changes

@GraceJansen GraceJansen GraceJansen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@revijay @mswatosh @GraceJansen