Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SSO docs #292

Merged
merged 7 commits into from
Aug 16, 2023
Merged

Update SSO docs #292

merged 7 commits into from
Aug 16, 2023

Conversation

pmeulen
Copy link
Member

@pmeulen pmeulen commented Aug 15, 2023

No description provided.

@pmeulen pmeulen requested a review from MKodde August 15, 2023 14:36
@MKodde MKodde added the 4.2 label Aug 16, 2023
Copy link
Member

@MKodde MKodde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, this reads like a book now.

I found one issue that might need attention.

docs/SsoOn2Fa.md Outdated Show resolved Hide resolved
MKodde and others added 6 commits August 16, 2023 13:53
The cookie lifetime can be extended by the user. But the explicit
lifetime of the cookie was not yet validated by the cookie service.
Meaning you could extend the SSO lifetime by keeping your cookie alive.

As of this change, the authentication lifetime is checked against the
current timestamp togegher with the cookie expiration time.

See: https://www.pivotaltracker.com/story/show/183402734
 -> the SSO cookie's timestamp is within the configured SSO lifetime
See the docs/SsoOn2Fa.md for details on why this construction was added.
Add missing word
Rebase to include grace period introduced in beta3
Add missing word
…-Gateway into feature/sso-doc-update

* 'feature/sso-doc-update' of github.com:OpenConext/Stepup-Gateway:
  Update SsoOn2Fa.md
  Update SSO docs

# Conflicts:
#	docs/SsoOn2Fa.md
@pmeulen pmeulen merged commit 7fefc7c into develop Aug 16, 2023
1 of 2 checks passed
@pmeulen pmeulen deleted the feature/sso-doc-update branch August 16, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants