Resolve SF deprecation warnings #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
force-pushed
the
maintenance/resolve-deprecations
branch
2 times, most recently
from
d31202d
to
0f7ab0d
Compare
johanib
approved these changes
Aug 14, 2023
| @@ -1,7 +1,7 @@ | |||
| filter: | |||
| excluded_paths: | |||
| - "*/Tests/*" | |||
| - "app/DoctrineMigrations/*" | |||
There was a problem hiding this comment.
Is this not included in the previous line? Or is it case sensitive?
There was a problem hiding this comment.
Thanks, I was mislead by the removed line. I later found out that the newly added line was not having the effect I looked for. And I'm going to remove it once again. But your feedback is interesting, I do not think the excluded path regex is not performed in a case insensitive manner.
| @@ -19,8 +19,8 @@ | |||
| namespace Surfnet\StepupGateway\GatewayBundle\Saml\Proxy; | |||
|
|
|||
| use Surfnet\StepupGateway\GatewayBundle\Saml\Exception\RuntimeException; | |||
| use Symfony\Component\HttpFoundation\Session\SessionBagInterface; | |||
There was a problem hiding this comment.
SessionBagInterface is not used in this file? Why is an import needed?
If this is really an error, consider tooling that removes unused imports.
There was a problem hiding this comment.
Thanks, removed that import
The NamespacedAttributeBag is replaced with the AttributeBag
MKodde
force-pushed
the
maintenance/resolve-deprecations
branch
from
0f7ab0d
to
4f64c28
Compare
Migrations are managed via Stepup-Middleware. Having them in this project makes no sense. And might cause confusion
MKodde
force-pushed
the
maintenance/resolve-deprecations
branch
from
4f64c28
to
f0c1dc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite some warnings where resolved. The Behat output (see QA run on GHA) is now almost cleaned up. The one remaining warning there is the one triggered via the JS Translation Bundle:
User Deprecated: The Symfony\Bundle\TwigBundle\Loader\FilesystemLoader class is deprecated since version 4.3 and will be removed in 5.0; use Twig notation for templates instead.We could rid ourself of that by simply upgrading the bundle, but that requires us to also upgrade to PHP8. So let's skip that for now.