Address some Symfony upgrade leftovers #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using binding, we can set the isDeprovisionApi parameter value with the value configured in parameters.yaml. Previously a compiler pass was used for this. But that construction did not work any longer
MKodde
force-pushed
the
chore/dev-left-overs
branch
from
abd694c
to
1e989bd
Compare
johanib
reviewed
Aug 28, 2024
| @@ -13,7 +13,6 @@ | |||
| /vendor/ | |||
| /web/bundles/ | |||
| /.idea | |||
| .env | |||
There was a problem hiding this comment.
Why remove this? Cant hurt to leave it there and prevent potential credential leaks?
There was a problem hiding this comment.
We could leave it, but makes little sense if we do not eval/use them.
| @@ -8,6 +8,8 @@ imports: | |||
|
|
|||
| services: | |||
| _defaults: | |||
| bind: | |||
| $isDeprovisionApi: '%deprovision_api_settings_enabled%' | |||
There was a problem hiding this comment.
This is convention or configured. I assume this looks at the feature toggle below :)
| @@ -271,16 +271,16 @@ | |||
| }, | |||
| { | |||
| "name": "doctrine/dbal", | |||
| "version": "4.0.2", | |||
| "version": "4.1.0", | |||
There was a problem hiding this comment.
Why not adopt composer bump to make your reviewer's live easier? ;)
johanib
approved these changes
Aug 28, 2024
MKodde
commented
Aug 28, 2024
| @@ -13,7 +13,6 @@ | |||
| /vendor/ | |||
| /web/bundles/ | |||
| /.idea | |||
| .env | |||
There was a problem hiding this comment.
We do not use .env files, but use the more traditional parameters.yaml way of configuring app parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit describes what changed