Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Symfony 7 and PHP 8.2 #67

Merged
merged 49 commits into from
Jun 3, 2024
Merged

Upgrade to Symfony 7 and PHP 8.2 #67

merged 49 commits into from
Jun 3, 2024

Conversation

parijke
Copy link
Contributor

@parijke parijke commented Apr 25, 2024 •
edited
Loading

Upgraded Symfony 7, PHP 8.2

  • cleaned up services.yaml to do as much autowiring en -configuring as possible
  • renamed parameters to new standard
  • disable dotenv functionality
  • use QA tools from other projects
  • merged config files to use the 'when@' syntax
  • upgraded almost all recipes

MKodde
MKodde requested changes May 21, 2024
View reviewed changes
Copy link
Member

@MKodde MKodde left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. See some review point below. Also check the PHPCS qa task. That one seems to allow for failues?

.gitignore Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
ci/qa/phpstan.neon Outdated Show resolved Hide resolved
ci/qa/phpunit Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
src/OpenConext/Kernel.php Outdated Show resolved Hide resolved
src/OpenConext/UserLifecycle/Domain/Client/InformationResponseFactoryInterface.php Show resolved Hide resolved
src/OpenConext/UserLifecycle/Domain/ValueObject/InactivityPeriod.php Show resolved Hide resolved
src/OpenConext/UserLifecycle/Domain/ValueObject/InactivityPeriod.php Outdated Show resolved Hide resolved
@MKodde MKodde changed the title Feature/sf7 upgrade Upgrade to Symfony 7 and PHP 8.2 May 21, 2024
parijke
parijke commented May 21, 2024
View reviewed changes
Copy link
Contributor Author

@parijke parijke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have answered most of the questions, and addressed some issues

@parijke parijke merged commit 8289f91 into main Jun 3, 2024
1 check passed
@parijke parijke deleted the feature/sf7-upgrade branch June 3, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quartje quartje quartje left review comments

@MKodde MKodde MKodde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parijke @quartje @MKodde @thijskh