Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Handle errors for payloads #1933

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[backend] Handle errors for payloads #1933

wants to merge 3 commits into from

Conversation

damgouj
Copy link
Member

@damgouj damgouj commented Nov 27, 2024

Proposed changes

  • Handle errors for executable payload like command line payload

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

This PR is linked with an implant PR

@damgouj damgouj self-assigned this Nov 27, 2024
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.62%. Comparing base (a20d4d6) to head (527221d).

Files with missing lines Patch % Lines
...ain/java/io/openbas/rest/injector/InjectorApi.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1933   +/-   ##
=========================================
  Coverage     33.62%   33.62%           
  Complexity     1671     1671           
=========================================
  Files           572      572           
  Lines         16697    16697           
  Branches        970      970           
=========================================
  Hits           5614     5614           
  Misses        10829    10829           
  Partials        254      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isselparra isselparra self-requested a review November 27, 2024 08:51
@damgouj damgouj marked this pull request as draft November 28, 2024 07:46
@damgouj damgouj marked this pull request as ready for review November 28, 2024 09:23
@damgouj damgouj changed the title [backend] Handle errors for executable payload [backend] Handle errors for payloads Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on executable payload not handle correclty
3 participants