Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] After deleting all expectations from a technical/media/challenge inject, an expectation is added by default to inject again #1923

Open
wants to merge 1 commit into
base: release/1.10.0
Choose a base branch
from

Conversation

isselparra
Copy link
Member

@isselparra isselparra commented Nov 26, 2024

Proposed changes

  • On Inject update, empty of predefined expectations since they are no needed if all the expectations where removed by the user

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.62%. Comparing base (a20d4d6) to head (a802543).

Additional details and impacted files
@@                Coverage Diff                @@
##             release/1.10.0    #1923   +/-   ##
=================================================
  Coverage             33.62%   33.62%           
  Complexity             1671     1671           
=================================================
  Files                   572      572           
  Lines                 16697    16697           
  Branches                970      970           
=================================================
  Hits                   5614     5614           
  Misses                10829    10829           
  Partials                254      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isselparra isselparra changed the base branch from master to release/1.10.0 November 29, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
1 participant