[backend] Fix on NPE in case of data being null #1859
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
filigran team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1859 +/- ##
=========================================
Coverage 32.42% 32.42%
Complexity 1623 1623
=========================================
Files 561 561
Lines 16834 16834
Branches 984 984
=========================================
Hits 5459 5459
Misses 11133 11133
Partials 242 242 ☔ View full report in Codecov by Sentry. |
Comment on lines
+103
to
+105
| this.client.endpoints().getData() != null | ||
| ? this.client.endpoints().getData().getEndpoints().getEdges().stream().toList() | ||
| : new ArrayList<>(); |
There was a problem hiding this comment.
Do we maybe want to log the error : it can help us detect a problem witth the Tanium excecutor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...