Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nothing to see here #54

Merged
merged 4 commits into from
Dec 17, 2018
Merged

Nothing to see here #54

merged 4 commits into from
Dec 17, 2018

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Dec 9, 2018

Address part of #42 . I am still not familiar of plugin stuff, so if there is a better way to do this, please advise. Also would like to know how to let individual repo customize the settings (e.g., adding more special days).

@codecov-io
Copy link

codecov-io commented Dec 9, 2018

Codecov Report

Merging #54 into master will decrease coverage by 0.13%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   81.75%   81.61%   -0.14%     
==========================================
  Files          15       15              
  Lines         762      778      +16     
==========================================
+ Hits          623      635      +12     
- Misses        139      143       +4
Impacted Files Coverage Δ
baldrick/utils.py 96.96% <100%> (+6.96%) ⬆️
baldrick/github/github_api.py 64.06% <20%> (-2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 179eb16...4ea4090. Read the comment docs.

@pllim pllim added the enhancement New feature or request label Dec 9, 2018
@Cadair
Copy link
Member

Cadair commented Dec 15, 2018

needs a rebase 😄

@pllim
Copy link
Contributor Author

pllim commented Dec 17, 2018

Rebased!

@Cadair Cadair merged commit 14176c8 into OpenAstronomy:master Dec 17, 2018
@pllim pllim deleted the special-msg branch December 17, 2018 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants