Make default validators compatible with new gTLDs by no longer validating TLDs against a whitelist #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
July 21, 2014 10:26
added 3 commits
July 21, 2014 15:21
|
Now ready for merge |
added 2 commits
July 21, 2014 16:42
…ion, make relaxed default
… e-mail validators using localpartRelaxed
|
Sorry two more commits, @papandreou also suggested to get rid of the non-relaxed version of e-mail localpart validation as the non-relaxed variant isn't useful. |
papandreou
added a commit
that referenced
this pull request
Jul 21, 2014
Make default validators compatible with new gTLDs by no longer validating TLDs against a whitelist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the gTLDs have hit the scene, the use case for validating a domain against a whitelist has become less practical.
Instead of the whitelist, this PR changes the default behaviour of the
domainandemailvalidators, to instead use the regexes that until now had been calleddomainRelaxed,emailRelaxedetc.This also supports the use case in #5 - even though that was already solved some months ago with commit 8db3cf9