Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New List-Runbooks, List-RunbookRuns and Delete-RunbookRuns commands #243

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mraming
Copy link

@mraming mraming commented Sep 25, 2022

This PR adds support for 3 new commands in the Octopus CLI which I needed:

  • List-Runbooks
  • List-RunbookRuns
  • Delete-RunbookRuns

Resolves #244

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2022

CLA assistant check
All committers have signed the CLA.

@jbristowe
Copy link
Contributor

jbristowe commented Sep 26, 2022

Hey @mraming! 👋 Thank you very much for your PR. I'm in the midst of reviewing it and I have some changes that I wish to recommend.

Would it also be possible to write up an issue to outline the need for these operations?

@mraming mraming changed the title New List-Runbooks, List-RunbookRuns and Delete-RunbookRuns commands a… New List-Runbooks, List-RunbookRuns and Delete-RunbookRuns commands Sep 27, 2022
…ents to prevent accidental deletion of all runs. Refactored actual delete command for runbook runs.
@mraming
Copy link
Author

mraming commented Sep 27, 2022

Hi @jbristowe,

I've implemented all the recommendations you've made - thanks for the suggestions! I've also opened up issue #244 with a (very) brief description of my reason for adding these 3 commands. Let me know if this is adequate.

As far as I'm concerned, you can go ahead and review the rework. Any and all suggestions and feedback are much appreciated!

Thanks,
Mark

@jbristowe
Copy link
Contributor

Thanks! That's awesome. I'll review the changes ASAP.

@mraming
Copy link
Author

mraming commented Oct 10, 2022

Hi @jbristowe , just wanted to check in to see if there's anything else you need from me with respect to this PR? I realize you must be busy but just want to make sure there's nothing else I can do to help.

@mraming
Copy link
Author

mraming commented Dec 6, 2022

Thanks! That's awesome. I'll review the changes ASAP.

Hi @jbristowe - sorry to keep pestering you... Is there anything I can do to help get this PR completed?

@jbristowe
Copy link
Contributor

Hey @mraming. Apologies for the delay. I'm curious to know which version of Octopus you are targeting?

@mraming
Copy link
Author

mraming commented Dec 6, 2022

Hey @mraming. Apologies for the delay. I'm curious to know which version of Octopus you are targeting?
@jbristowe, I've been using this targeting Octopus running in a Linux Container. I believe I've used it last with version 2022.3.10723.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional support for listing and deleting of Runbook Runs
3 participants