-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New List-Runbooks, List-RunbookRuns and Delete-RunbookRuns commands #243
base: main
Are you sure you want to change the base?
New List-Runbooks, List-RunbookRuns and Delete-RunbookRuns commands #243
Conversation
Hey @mraming! 👋 Thank you very much for your PR. I'm in the midst of reviewing it and I have some changes that I wish to recommend. Would it also be possible to write up an issue to outline the need for these operations? |
source/Octopus.Cli/Commands/RunbookRun/ListRunbookRunsCommand.cs
Outdated
Show resolved
Hide resolved
source/Octopus.Cli/Commands/RunbookRun/DeleteRunbookRunsCommand.cs
Outdated
Show resolved
Hide resolved
source/Octopus.Cli/Commands/RunbookRun/DeleteRunbookRunsCommand.cs
Outdated
Show resolved
Hide resolved
…Runs and Delete-RunbookRuns commands
…ents to prevent accidental deletion of all runs. Refactored actual delete command for runbook runs.
Hi @jbristowe, I've implemented all the recommendations you've made - thanks for the suggestions! I've also opened up issue #244 with a (very) brief description of my reason for adding these 3 commands. Let me know if this is adequate. As far as I'm concerned, you can go ahead and review the rework. Any and all suggestions and feedback are much appreciated! Thanks, |
Thanks! That's awesome. I'll review the changes ASAP. |
Hi @jbristowe , just wanted to check in to see if there's anything else you need from me with respect to this PR? I realize you must be busy but just want to make sure there's nothing else I can do to help. |
Hi @jbristowe - sorry to keep pestering you... Is there anything I can do to help get this PR completed? |
Hey @mraming. Apologies for the delay. I'm curious to know which version of Octopus you are targeting? |
|
This PR adds support for 3 new commands in the Octopus CLI which I needed:
Resolves #244