Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db/MySQL: fix HTML manual nested <ul></ul> element position #4778

Merged

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Nov 28, 2024

Fix HTMLParser() class instance find nested <ul> end element </ul> error during compilation GRASS GIS source code:

Error (IndexError('pop from empty list'))

Problematic is nested <ul></ul> HTML element inside parent <ul></ul> element:

 <ul>
     <li></li>
     <li></li>
      <ul>
          <li></li>
          <li></li>
          <li></li>
      </ul>
 </ul>

Expected nested <ul></ul> HTML element inside parent <ul></ul> is nested position inside <li></li> element.

<ul>
    <li></li>
    <li>
        <ul>
            <li></li>
            <li></li>
            <li></li>
        </ul>
    </li>
</ul>

Fixes #4777.

Fix `HTMLParser()` class instance find nested `<ul>` end element `</ul>`
error during compilation GRASS GIS source code:

```
Error (IndexError('pop from empty list'))
```

Problematic is nested `<ul></ul>` HTML element inside parent `<ul></ul>`
element:

```
 <ul>
     <li></li>
     <li></li>
      <ul>
          <li></li>
          <li></li>
          <li></li>
      </ul>
 </ul>
```

Expected nested `<ul></ul>` HTML element inside parent `<ul></ul>` is
nested position inside `<li></li>` element.

```
<ul>
    <li></li>
    <li>
        <ul>
            <li></li>
            <li></li>
            <li></li>
        </ul>
    </li>
</ul>
```
@tmszi tmszi added bug Something isn't working HTML Related code is in HTML backport to 8.4 PR needs to be backported to release branch 8.4 labels Nov 28, 2024
@tmszi tmszi added this to the 8.4.1 milestone Nov 28, 2024
@tmszi tmszi self-assigned this Nov 28, 2024
@github-actions github-actions bot added database Related to database management module docs labels Nov 28, 2024
echoix
echoix previously approved these changes Nov 28, 2024
db/drivers/mysql/grass-mysql.html Outdated Show resolved Hide resolved
@tmszi tmszi merged commit 378834b into OSGeo:main Nov 28, 2024
22 of 23 checks passed
@tmszi tmszi deleted the fix-mysql-db-driver-html-page-nested-ul-element branch November 28, 2024 13:37
tmszi added a commit that referenced this pull request Nov 28, 2024
* db/MySQL: fix HTML manual nested `<ul></ul>` element position

Fix `HTMLParser()` class instance find nested `<ul>` end element `</ul>`
error during compilation GRASS GIS source code:

```
Error (IndexError('pop from empty list'))
```

Problematic is nested `<ul></ul>` HTML element inside parent `<ul></ul>`
element:

```
 <ul>
     <li></li>
     <li></li>
      <ul>
          <li></li>
          <li></li>
          <li></li>
      </ul>
 </ul>
```

Expected nested `<ul></ul>` HTML element inside parent `<ul></ul>` is
nested position inside `<li></li>` element.

```
<ul>
    <li></li>
    <li>
        <ul>
            <li></li>
            <li></li>
            <li></li>
        </ul>
    </li>
</ul>
```

* Fix typo of key word
@neteler neteler removed the backport to 8.4 PR needs to be backported to release branch 8.4 label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working database Related to database management docs HTML Related code is in HTML module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] GRASS GIS source code compilation process fails if MySQL DB backend support is enabled
3 participants