-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: fix duplicate messsages in po files #4722
Conversation
This PR deduplicates the message files. I used the following command (inspired by @HuidaeCho in OSGeo#1396 (comment)): ``` cd locale/po/ for pofile in $(ls grass*.po); do sed -n '{/^#~/!{p}}' ${pofile} > ${pofile}.tmp msguniq --use-first ${pofile}.tmp > ${pofile} rm -f ${pofile}.tmp done ```
It seems a lot of deletions (40k vs 20 (unit) ish additions). Has a spot check been made to be sure we aren't losing too much work? |
Only comments have been removed. Again, I am following @HuidaeCho's advice (see reference above). |
Would a full collection of new strings be appropriate? We never got it updated since I worked on fixing the python strings that formatted before calling gettext (INT003 and all) |
Yes, but probably in a new PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked them all. There were the two duplicates in russian, that have different translations, and there is in spanish and italian that the strings aren't translated to the same contents, but for spanish for example, that same string is also for 2 other source strings, and only one is fuzzy.
So, its fine for me to potentially degrade 2-6 strings for all languages.
Thanks for the thorough review! |
You disabled auto-merge for the PR? |
I accidentally activated it, the deactivated it again since it will not run due to the current Travis CI bug. |
This PR deduplicates the message files (currently the compilation is broken), apparently introduced in #4710 .
I used the following command (inspired by @HuidaeCho in #1396 (comment)):Edit: keeping the commented cruft in the PO files: