Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: Fix locales in development environment #4540

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

imincik
Copy link
Contributor

@imincik imincik commented Oct 17, 2024

Description

Fix locales in nix provided development environment.

Closes: #4503

Motivation and context

How has this been tested?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to not work as before)

Checklist

  • My code follows the code style
    of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully tested this locally earlier. I was actually suggesting you do it to ensure there is proper documentation of the change which I cannot do. I guess having it done by you is also a type of documentation :-)

@wenzeslaus wenzeslaus changed the title nix: fix locales in development environment nix: Fix locales in development environment Oct 17, 2024
@wenzeslaus wenzeslaus merged commit e540efc into OSGeo:main Oct 17, 2024
28 checks passed
@wenzeslaus
Copy link
Member

Merged, thank you!

@github-actions github-actions bot added this to the 8.5.0 milestone Oct 17, 2024
@a0x8o a0x8o mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The init needs to fall back to C locale in Nix environment
3 participants