Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: MSVC 64-bit cleanup #11318

Merged
merged 2 commits into from
Nov 20, 2024
Merged

CMake: MSVC 64-bit cleanup #11318

merged 2 commits into from
Nov 20, 2024

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Nov 20, 2024

What does this PR do?

This PR revises CMake code for MSVC.

Tasklist

  • Review
  • Adjust for comments
  • All CI builds and checks have passed

Environment

Provide environment details, if relevant:

  • OS: Windows
  • Compiler: MSVC

No local testing due to no MSVC.

@rouault rouault added the backport release/3.10 Backport to release/3.10 branch label Nov 20, 2024
@dg0yt
Copy link
Contributor Author

dg0yt commented Nov 20, 2024

Removed FindDB2.cmake.
There are interesting hits for git grep DB2 (frmts/drivers.ini, and HACK_FOR_IBM_DB2_V72), but this out of scope for this PR.

@rouault
Copy link
Member

rouault commented Nov 20, 2024

frmts/drivers.ini,

just removed that one

HACK_FOR_IBM_DB2_V72

hum, that one dates back to times where I was hardly born. It doesn't related with the DB2 driver that was added (and eventually removed) after this HACK_FOR_IBM_DB2_V72

@rouault rouault merged commit 50585ef into OSGeo:master Nov 20, 2024
37 checks passed
@dg0yt dg0yt deleted the 64 branch November 21, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/3.10 Backport to release/3.10 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants