Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stricter typing for void* pTransformerArg #10964

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rouault
Copy link
Member

@rouault rouault commented Oct 8, 2024

@elpaso Implements what you discussed in #10952 (comment)

The last commit ("Make GDALTransformerArg a typedef of an anonymous struct GDALTransformerArgOpaque*") is slightly backwards incompatible

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 69.434%. remained the same
when pulling b9d0adb on rouault:GDALTransformerArg
into 15b4921 on OSGeo:master.

@rouault
Copy link
Member Author

rouault commented Oct 9, 2024

The last commit ("Make GDALTransformerArg a typedef of an anonymous struct GDALTransformerArgOpaque*") is slightly backwards incompatible

We might also postpone this to 3.11, as there's no emergency in merging this, especially if @dbaston would want a cleaner way of doing proper C++ typing.

@rouault rouault added the funded through GSP Work funded through the GDAL Sponsorship Program label Oct 24, 2024
Copy link

The GDAL project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 28 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular link
    to any issues which this pull request fixes

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in 2 weeks.

@github-actions github-actions bot added the stale label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
funded through GSP Work funded through the GDAL Sponsorship Program stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants