Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version and update changelog #824

Merged
merged 4 commits into from
Jan 31, 2024
Merged

bump version and update changelog #824

merged 4 commits into from
Jan 31, 2024

Conversation

johrstrom
Copy link
Contributor

bump version and update changelog

CHANGELOG.md Outdated
Comment on lines 532 to 535
[Unreleased]: https://github.com/OSC/ood_core/compare/v0.24.2...HEAD
[0.24.2]: https://github.com/OSC/ood_core/compare/v0.24.2...v0.24.1
[0.24.1]: https://github.com/OSC/ood_core/compare/v0.24.1...v0.24.0
[0.24.0]: https://github.com/OSC/ood_core/compare/v0.24.0...v0.23.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those version numbers at the end right? My brain wants these the other way v0.23.5...v0.24.0 etc. Am I reading that wrong?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! You're right, they're backwards.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and oddly enough, it was just that one link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, now I'm all mixed up. It should be lower...higher. They're links, so they should actually link to something correct. I'm validating them all now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK - I think they're all correct now.

Copy link
Contributor

@Oglopf Oglopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@johrstrom johrstrom merged commit 41fec50 into master Jan 31, 2024
3 checks passed
@johrstrom johrstrom deleted the next-version branch January 31, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants