Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CAAM AEAD support #7116

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

sahilnxp
Copy link
Contributor

@sahilnxp sahilnxp commented Nov 8, 2024

This pull request add support for CAAM AEAD support.

@omasse-linaro

@sahilnxp
Copy link
Contributor Author

sahilnxp commented Nov 8, 2024

CI reported some issues, I will update the pull request.

@sahilnxp sahilnxp force-pushed the github_master_caam_aead branch 2 times, most recently from 2db2095 to d05d2ef Compare November 12, 2024 18:09
@sahilnxp
Copy link
Contributor Author

CI reported issues taken case.
This PR is ready for review.

Copy link
Contributor

@jenswi-linaro jenswi-linaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments for the commit "drivers: caam: Add caam_cpy_buf_src()"

core/drivers/crypto/caam/include/caam_utils_mem.h Outdated Show resolved Hide resolved
core/drivers/crypto/caam/include/caam_utils_mem.h Outdated Show resolved Hide resolved
core/drivers/crypto/caam/utils/utils_mem.c Show resolved Hide resolved
@jenswi-linaro
Copy link
Contributor

@sahilnxp, please add your Signed-off-by to the commits since this is your pull request.

Copy link
Contributor

@jenswi-linaro jenswi-linaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments for the commit "drivers: caam: Add AES GCM"

Please drop the "CAAM Errata" part from the commit message, it's enough to have it at the implementation to explain what's going on.

core/drivers/crypto/caam/ae/sub.mk Outdated Show resolved Hide resolved
core/drivers/crypto/caam/ae/local.h Outdated Show resolved Hide resolved
core/drivers/crypto/caam/ae/local.h Outdated Show resolved Hide resolved
Copy link
Contributor

@jenswi-linaro jenswi-linaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments for the commit "drivers: caam: Add AES CCM"

core/drivers/crypto/caam/ae/caam_ae_ccm.c Outdated Show resolved Hide resolved
core/drivers/crypto/caam/ae/caam_ae_ccm.c Outdated Show resolved Hide resolved
core/drivers/crypto/caam/ae/caam_ae.c Outdated Show resolved Hide resolved
core/drivers/crypto/caam/ae/caam_ae.c Outdated Show resolved Hide resolved
core/drivers/crypto/caam/ae/caam_ae.c Outdated Show resolved Hide resolved
core/drivers/crypto/caam/ae/caam_ae.c Outdated Show resolved Hide resolved
core/drivers/crypto/caam/ae/caam_ae_ccm.c Outdated Show resolved Hide resolved
core/drivers/crypto/caam/ae/caam_ae_gcm.c Outdated Show resolved Hide resolved
core/drivers/crypto/caam/ae/caam_ae_gcm.c Outdated Show resolved Hide resolved
core/drivers/crypto/caam/ae/caam_ae_gcm.c Outdated Show resolved Hide resolved
core/drivers/crypto/caam/ae/caam_ae_gcm.c Show resolved Hide resolved
core/drivers/crypto/caam/ae/caam_ae.c Show resolved Hide resolved
@sahilnxp sahilnxp force-pushed the github_master_caam_aead branch 4 times, most recently from f92371b to c19dbc6 Compare November 15, 2024 12:08
omasse-linaro and others added 7 commits November 15, 2024 13:10
Introduce Sequence Fifo load command

Signed-off-by: Olivier Masse <[email protected]>
Signed-off-by: Sahil Malhotra <[email protected]>
Introduce more CCB CLR WR register

Signed-off-by: Olivier Masse <[email protected]>
Signed-off-by: Sahil Malhotra <[email protected]>
Add caam_cpy_buf_src() function that copy a data buffer into a caam buffer.

Signed-off-by: Olivier Masse <[email protected]>
Signed-off-by: Sahil Malhotra <[email protected]>
Implement CAAM AES GCM

Signed-off-by: Olivier Masse <[email protected]>
Signed-off-by: Sahil Malhotra <[email protected]>
Implement CAAM AES CCM

Signed-off-by: Olivier Masse <[email protected]>
Signed-off-by: Sahil Malhotra <[email protected]>
imx6dl-sabresd, imx6q-sabresd, imx6sx-sdb does not support AES GCM

Signed-off-by: Olivier Masse <[email protected]>
Signed-off-by: Sahil Malhotra <[email protected]>
There has been an addition of CAAM AEAD driver, to include that need to
update imx-mx8mmevk compilation command in case of se050 enabled

Signed-off-by: Sahil Malhotra <[email protected]>
@sahilnxp
Copy link
Contributor Author

There was some issue at my side. because of which there has been multiple push to this pull request.
Sorry for that..

fixup! drivers: caam: Add caam_cpy_buf_src()

Signed-off-by: Sahil Malhotra <[email protected]>
fixup! drivers: caam: Add AES GCM

Signed-off-by: Sahil Malhotra <[email protected]>
fixup! drivers: caam: Add AES CCM

Signed-off-by: Sahil Malhotra <[email protected]>
@sahilnxp
Copy link
Contributor Author

Pull request updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants