no default path for shiny

OHDSI · Nov 1, 2024 · a387ca1 · a387ca1
1 parent a4d290b
commit a387ca1
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/R/shinyDiagnostics.R b/R/shinyDiagnostics.R
@@ -50,7 +50,7 @@
 #'   shinyDiagnostics(my_result_cohort_diag)
 #' }
 shinyDiagnostics <- function(result,
-                             directory = here::here()){
+                             directory){
 
   rlang::check_installed("OmopViewer")
 

diff --git a/man/shinyDiagnostics.Rd b/man/shinyDiagnostics.Rd
diff --git a/tests/testthat/test-dbms.R b/tests/testthat/test-dbms.R
@@ -18,7 +18,7 @@ test_that("eunomia", {
                                conceptSet = meds_cs,
                                name = "meds")
   results <- phenotypeDiagnostics(cdm$meds)
-  expect_no_error(shinyDiagnostics(result = results))
+  expect_no_error(shinyDiagnostics(result = results, directory = here::here()))
 })
 
 test_that("postgres test", {
@@ -49,7 +49,7 @@ test_that("postgres test", {
   cdm <- omopgenerics::bind(cdm$asthma, cdm$drugs, name = "my_cohort")
 
   results <- phenotypeDiagnostics(cdm$my_cohort)
-  expect_no_error(shinyDiagnostics(result = results))
+  expect_no_error(shinyDiagnostics(result = results, directory = here::here()))
   expect_no_error(CodelistGenerator::tableCohortCodeUse(results))
   expect_no_error(CodelistGenerator::tableAchillesCodeUse(results))
   expect_no_error(CodelistGenerator::tableOrphanCodes(results))
@@ -60,7 +60,7 @@ test_that("postgres test", {
   expect_no_error(CohortCharacteristics::tableCohortTiming(results))
   expect_no_error(CohortCharacteristics::tableLargeScaleCharacteristics(results))
   # omopViewer::exportStaticApp(results)
-  expect_no_error(shinyDiagnostics(result = results))
+  expect_no_error(shinyDiagnostics(result = results, directory = here::here()))
 
   CDMConnector::cdm_disconnect(cdm = cdm)
 

diff --git a/tests/testthat/test-shinyDiagnostics.R b/tests/testthat/test-shinyDiagnostics.R
@@ -38,7 +38,8 @@ test_that("basic working example with one cohort", {
 
   my_result_cohort_diag <- cdm$my_cohort |> phenotypeDiagnostics()
 
-  expect_no_error(shinyDiagnostics(my_result_cohort_diag))
+  expect_no_error(shinyDiagnostics(my_result_cohort_diag,
+                                   directory = here::here()))
 
 
 })