Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix img src and max-height #244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix img src and max-height #244

wants to merge 1 commit into from

Conversation

lena-hinrichsen
Copy link
Member

No description provided.

kba
kba reviewed Mar 24, 2023
View reviewed changes
Copy link
Member

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why, what is the probelm with <figure/>?

@lena-hinrichsen
Copy link
Member Author

lena-hinrichsen commented Mar 24, 2023 •
edited
Loading

Why, what is the probelm with <figure/>?

The class does not neccessarily have to be changed, as it seems. that happened when I copy pasted a block from another page (about) where we use figure img.

The important change is the image src, max-height and the href I think

kba
kba approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I was just curious, looks legit otherwise, feel free to publish

kba
kba requested changes Mar 24, 2023
View reviewed changes
Copy link
Member

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not realize this is OCR-D/spec not OCR-D/website. I need to adapt make spec in OCR-D/website, please don't merge for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kba kba kba requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lena-hinrichsen @kba