Add docker build target and introduce pyprojct.toml #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kba
approved these changes
Oct 16, 2024
Co-authored-by: Konstantin Baierer <[email protected]>
Co-authored-by: Konstantin Baierer <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to provide a Dockerfile and a makefile target/task to build the image for this processor. Also I switched from setup.py to pyproject.toml. The so far used setup.py was not working for me to successfully install the processor in the dockerimage.
I also "just" added the Apache License, because ocrd-core uses the same. I saw that many processors use MIT license, maybe that is better to use? I think the dependencies from requirements.txt all have BSD License so are compatible with Apache 2 License. So from my point of view this should fit but other than that I have no idea if it is a good idea to add the license. Maybe that should be done in a separate step but maybe this can be done in one go here too.
This is a draft for now because I am not sure about the license. Other than that I have tested the froc-dockerfile and the installation with pyproject.toml and it is working for me, so ready to be merged in this regards.