[17.0][MIG] contract_membership_delegated_partner: Migration to 17.0 #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ocabot rebase |
- Adaptation to the new OCA contract module paradigm.
Update "development_status": "Production/Stable"
[UPD] Update contract_membership_delegated_partner.pot [BOT] post-merge updates
…elds are always truthy This is an additional sanity check to make sure that fields that are expected to be available are actually available. The situation here is a little tricky. Especially as pertains date_from and date_to; these fields are `required=True` nowhere. Not on the product, not on the membership invoice, and not on the membership line. However, they _are_ set as required in the product and membership line views. If these values are ever empty, it's a sure sign that something went wrong somewhere, because the user should not be able to reach such a state via the UI. One sure way to reach that state was via the demo data, however, which had no start and end dates. This is now fixed. The situation for the variable period fields is similar. These fields should never be empty when the membership type is variable, and it's not typically possible to empty these values via the UI. For convenience's sake, I simply set them to required an sich, with a default value. Signed-off-by: Carmen Bianca BAKKER <[email protected]> [BOT] post-merge updates
victoralmau
force-pushed
the
17.0-mig-contract_membership_delegated_partner
branch
from
304b1cb
to
1e36f06
Compare
|
/ocabot migration contract_membership_delegated_partner |
pedrobaeza
approved these changes
Nov 15, 2024
chienandalu
approved these changes
Nov 15, 2024
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 42346da. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
17.0-mig-contract_membership_delegated_partner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to 17.0
Locked by:
membership_delegated_partner: [17.0][MIG] membership_delegated_partner: Migration to 17.0 #185@Tecnativa TT51523