Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][ADD] pos_product_pack #67

Merged
merged 14 commits into from
Sep 5, 2024
Merged

[14.0][ADD] pos_product_pack #67

merged 14 commits into from
Sep 5, 2024

Conversation

rousseldenis
Copy link
Contributor

@rousseldenis rousseldenis commented Jan 12, 2022 •
edited
Loading

  • Take into account pack lines quantities (1 for now). Added in ROADMAP

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 15, 2022
@github-actions github-actions bot closed this Jun 19, 2022
@rousseldenis
Copy link
Contributor Author

Still applicable

@rousseldenis rousseldenis reopened this Jun 20, 2022
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 26, 2022
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 30, 2022
@github-actions github-actions bot closed this Dec 4, 2022
@rousseldenis rousseldenis reopened this Jan 6, 2023
@rousseldenis rousseldenis marked this pull request as ready for review January 6, 2023 15:20
baimont
baimont approved these changes Jan 9, 2023
View reviewed changes
Copy link

@baimont baimont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review, thanks @rousseldenis

FrancoMaxime
FrancoMaxime approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@FrancoMaxime FrancoMaxime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, thanks @rousseldenis

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza added this to the 14.0 milestone Jan 9, 2023
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 15, 2023
@apineux apineux force-pushed the 14.0-add-pos_product_pack-dro branch 2 times, most recently from 5f81c22 to 0de10e2 Compare February 3, 2023 13:57
@apineux apineux force-pushed the 14.0-add-pos_product_pack-dro branch 3 times, most recently from c10fa53 to 3279b02 Compare February 14, 2023 12:47
@rousseldenis
Copy link
Contributor Author

@apineux Is this ready ?

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 16, 2023
@github-actions github-actions bot closed this Aug 20, 2023
@Bilbonet
Copy link

Bilbonet commented Mar 6, 2024

Hi @rousseldenis

I find this module very useful.
It's a shame that it's not merged into the repo.

I've been doing tests with the module and I have an issue.
In the POS always shows the pack detailed with the price of the pack and the prices of the products that belongs to it.
Regardless the options you set in the product form.

Maybe if you are still interested in carry on with your work, I'll do test and reviews that can help to finally merge the module.

Thanks in advance for your work and attention.

@rousseldenis rousseldenis reopened this Apr 17, 2024
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 21, 2024
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 25, 2024
rousseldenis and others added 13 commits September 5, 2024 09:35
@rousseldenis
[14.0][ADD] pos_product_pack
19c8240
@rousseldenis
[14.0][FIX] pos_product_pack: Save pack lines to db at each push
2989a4b
@rousseldenis
[IMP] pos_product_pack: Save pack line and improve code
6d00836
@rousseldenis
[IMP] pos_product_pack: Avoid setting twice the quantity when adding …
a4f2667 
…parent pack
@rousseldenis
[IMP] pos_product_pack: Improve display to identify pack lines
f3d343c
@rousseldenis
[IMP] pos_product_pack: Check if linked product can be merged
a5bda21
@rousseldenis
[IMP] pos_product_pack: Try to merge (add quantity) instead of using …
94c55d8 
…can merge with
@rousseldenis
[IMP] pos_product_pack: Improve code
9943023
@rousseldenis
[IMP] pos_product_pack: Improve README
1a90c39
@rousseldenis
[FIX] pos_product_pack: Remove the child line in parent on child removal
9bac7bd
@apineux @rousseldenis
[FIX] pos_product_pack: pack_parent_line_id is not necessary on the p…
87554bf 
…os.order.line
@apineux @rousseldenis
[FIX] pos_product_pack: pack_line_id should be loaded at initialization
fc8102a
@apineux @rousseldenis
[FIX] pack line should work after closing and reopening the POS session
8066311
@rousseldenis
Copy link
Contributor Author

@Bilbonet Thanks. We will merge this and then, improvements could be done with further PR's

@rousseldenis
Copy link
Contributor Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-67-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c80720d into OCA:14.0 Sep 5, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7ad13f4. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baimont baimont baimont approved these changes

@FrancoMaxime FrancoMaxime FrancoMaxime approved these changes

@apineux apineux apineux approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
7 participants
@rousseldenis @OCA-git-bot @Bilbonet @apineux @FrancoMaxime @baimont @pedrobaeza