Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][FIX] website_sale_product_pack: add decorator to remove warnings #191

Merged
merged 1 commit into from
Nov 22, 2024
Merged

[17.0][FIX] website_sale_product_pack: add decorator to remove warnings #191

merged 1 commit into from
Nov 22, 2024

Conversation

Abranes
Copy link
Member

@Abranes Abranes commented Nov 22, 2024

Added route decorator to fix annoying warnings:

2024-11-22 07:57:10,327 18 WARNING b5a7dddd5-1e5e-4584-9d8f-426cb5efd411 odoo.http: The endpoint odoo.addons.website_sale_product_pack.controllers.main.WebsiteSale.shop is not decorated by @route(), decorating it myself. 
2024-11-22 07:57:10,351 18 WARNING b5a7dddd5-1e5e-4584-9d8f-426cb5efd411 odoo.http: The endpoint odoo.addons.website_sale_product_pack.controllers.variant.WebsiteSaleVariantController.get_combination_info_website is not decorated by @route(), decorating it myself.

@rousseldenis rousseldenis added the enhancement New feature or request label Nov 22, 2024
@rousseldenis rousseldenis added this to the 17.0 milestone Nov 22, 2024
@rousseldenis
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-191-by-rousseldenis-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e6f284c into OCA:17.0 Nov 22, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2111346. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Loregs2 Loregs2 Loregs2 approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@jaenbox jaenbox jaenbox approved these changes

Assignees
No one assigned
Labels
approved enhancement New feature or request merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Abranes @rousseldenis @OCA-git-bot @jaenbox @Loregs2