Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] mis_builder_analytic: Migration to 16.0 #49

Open
wants to merge 20 commits into
base: 16.0
Choose a base branch
from

Conversation

peluko00
Copy link

@peluko00 peluko00 commented Apr 24, 2024

Module migrated to version 16.0

cc https://github.com/APSL 154419
@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall please review

@peluko00 peluko00 mentioned this pull request Apr 24, 2024
2 tasks
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working correctly, checked in runboat

Copy link
Member

@douglascstd douglascstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[FUNCTIONAL REVIEW]

Thank you for migrating this module. It will be useful for everyone.

The selection by filters does not appear, even with the option selected
image
image

TEST
Bill:
image

Mis Builder Report:
image

Dropdown the value:
image

Investigation v14 and v16:
image
image
image

@peluko00
Copy link
Author

peluko00 commented May 2, 2024

[FUNCTIONAL REVIEW]

Thank you for migrating this module. It will be useful for everyone.

The selection by filters does not appear, even with the option selected image image

TEST Bill: image

Mis Builder Report: image

Dropdown the value: image

Investigation v14 and v16: image image image

This changes not affected to this module, review again please

@hitrosol
Copy link

runboat is not working...

@peluko00 peluko00 force-pushed the 16.0-mig-mis_builder_analytic branch from 718ecd2 to d72fc38 Compare August 15, 2024 06:34
@peluko00
Copy link
Author

runboat is not working...

Done!

@hitrosol
Copy link

Thanks for this migration.

It seems the module mis_builder in runboat is not updated, therefore the missing fields as @douglascstd said still not there.
I tried this on my local with the updated mis_builder and the missing fields are shown.

I have comments about this migration as following:

  1. If we use MIS Account Analytic Line as Move Lines Source, then the value in Filter box search view is missing:
Screen Shot 2024-08-15 at 16 04 03

Any plan to update that record so the user can filter the using analytic line in the report view ?

  1. Since v16 the analytic line is not easily grab from account.move.line, therefore it's time to support this module so we can make make dynamic report base on the account_analytic. I suggest to use analytic_account as basis of KPI expression. So whenever user put kpi, example: bale[], therefore it will refer to analytic_account not account. Then, the Auto Expand also can be refer to analytic_account as well. I'm hoping this feature can be adopted in the core of MIS Builder, if not, having this here will be okay as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants