Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] sale_margin_security: Migration to 17.0 #217

Open
wants to merge 35 commits into
base: 17.0
Choose a base branch
from

Conversation

jdidderen-nsi
Copy link

@jdidderen-nsi jdidderen-nsi commented Jul 12, 2024

chienandalu and others added 30 commits July 12, 2024 11:38
In sale_margin, when the line already exists, the purchase_price
is computed with the product onchange method, so if the user doesn't
have the field available in the view it's not going to get the right
price. This should be fixed in v13 with the new compute fields
possibilities.
Currently translated at 100.0% (2 of 2 strings)

Translation: margin-analysis-13.0/margin-analysis-13.0-sale_margin_security
Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-13-0/margin-analysis-13-0-sale_margin_security/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: margin-analysis-15.0/margin-analysis-15.0-sale_margin_security
Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-15-0/margin-analysis-15-0-sale_margin_security/
Currently translated at 100.0% (3 of 3 strings)

Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_security
Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_security/es/
Set group_sale_margin_security in all sensible fields.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_security
Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_security/
Currently translated at 85.7% (6 of 7 strings)

Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_security
Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_security/es/
Currently translated at 100.0% (7 of 7 strings)

Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_security
Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_security/es/
Currently translated at 100.0% (7 of 7 strings)

Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_security
Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_security/it/
Both modules do essentially the same thing: apply a restriction over product costs. Thus, it makes sense to share the same permission groups.

This refactor, that depends on OCA/product-attribute#1538, improves the module readme and makes `sale_margin_security` auto-installable addon when `product_cost_security` is found.

A migration script is provided to make sure the same users still retain the same permissions.

@moduon MT-5158
weblate and others added 4 commits July 12, 2024 11:38
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_security
Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_security/
Currently translated at 100.0% (7 of 7 strings)

Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_security
Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_security/it/
@OCA-git-bot
Copy link
Contributor

Hi @sergio-teruel, @carlosdauden,
some modules you are maintaining are being modified, check this out!

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.