-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] sale_margin_security: Migration to 17.0 #217
Open
jdidderen-nsi
wants to merge
35
commits into
OCA:17.0
Choose a base branch
from
jdidderen-nsi:17.0-mig-sale_margin_security
base: 17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[17.0][MIG] sale_margin_security: Migration to 17.0 #217
jdidderen-nsi
wants to merge
35
commits into
OCA:17.0
from
jdidderen-nsi:17.0-mig-sale_margin_security
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In sale_margin, when the line already exists, the purchase_price is computed with the product onchange method, so if the user doesn't have the field available in the view it's not going to get the right price. This should be fixed in v13 with the new compute fields possibilities.
Currently translated at 100.0% (2 of 2 strings) Translation: margin-analysis-13.0/margin-analysis-13.0-sale_margin_security Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-13-0/margin-analysis-13-0-sale_margin_security/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: margin-analysis-15.0/margin-analysis-15.0-sale_margin_security Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-15-0/margin-analysis-15-0-sale_margin_security/
Currently translated at 100.0% (3 of 3 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_security Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_security/es/
Set group_sale_margin_security in all sensible fields.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_security Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_security/
Currently translated at 85.7% (6 of 7 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_security Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_security/es/
Currently translated at 100.0% (7 of 7 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_security Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_security/es/
Currently translated at 100.0% (7 of 7 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_security Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_security/it/
Both modules do essentially the same thing: apply a restriction over product costs. Thus, it makes sense to share the same permission groups. This refactor, that depends on OCA/product-attribute#1538, improves the module readme and makes `sale_margin_security` auto-installable addon when `product_cost_security` is found. A migration script is provided to make sure the same users still retain the same permissions. @moduon MT-5158
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_security Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_security/
Currently translated at 100.0% (7 of 7 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_security Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_security/it/
Hi @sergio-teruel, @carlosdauden, |
jdidderen-nsi
force-pushed
the
17.0-mig-sale_margin_security
branch
from
July 12, 2024 10:04
8055b81
to
1a7b6aa
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
PR/Issue without recent activity, it'll be soon closed automatically.
label
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: