Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] account_invoice_margin_sale: Add post_install hook #216

Merged
merged 1 commit into from
Jul 16, 2024
Merged

[16.0][IMP] account_invoice_margin_sale: Add post_install hook #216

merged 1 commit into from
Jul 16, 2024

Conversation

carolinafernandez-tecnativa
Copy link

  • Add post_init_hook to update purchase cost in invoice lines from sale order when installing module.

@Tecnativa
TT49994
@pedrobaeza @victoralmau

@OCA-git-bot
Copy link
Contributor

Hi @carlosdauden, @sergio-teruel,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza changed the title [IMP] account_invoice_margin_sale: Update purchase cost in invoice lines from sale order when installing module [16.0][IMP] account_invoice_margin_sale: Update purchase cost in invoice lines from sale order when installing module Jul 8, 2024
@pedrobaeza pedrobaeza added this to the 16.0 milestone Jul 8, 2024
@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 16.0-imp-account_invoice_sale_margin branch 3 times, most recently from ccc0d72 to 72c361c Compare July 9, 2024 12:29
@carolinafernandez-tecnativa
Copy link
Author

ping @pedrobaeza

@carolinafernandez-tecnativa @pedrobaeza
[IMP] account_invoice_margin_sale: Add post_install hook
029eca4 
Update margin fields in invoice lines where there are values from sales
order when installing module.

TT49994
@pedrobaeza pedrobaeza force-pushed the 16.0-imp-account_invoice_sale_margin branch from 9222940 to 029eca4 Compare July 11, 2024 07:04
@pedrobaeza pedrobaeza changed the title [16.0][IMP] account_invoice_margin_sale: Update purchase cost in invoice lines from sale order when installing module [16.0][IMP] account_invoice_margin_sale: Add post_install hook Jul 11, 2024
carlos-lopez-tecnativa
carlos-lopez-tecnativa approved these changes Jul 15, 2024
View reviewed changes
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-216-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 766b4e4 into OCA:16.0 Jul 16, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9c4f767. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-imp-account_invoice_sale_margin branch July 16, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-lopez-tecnativa carlos-lopez-tecnativa carlos-lopez-tecnativa approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@sergio-teruel sergio-teruel Awaiting requested review from sergio-teruel

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@carolinafernandez-tecnativa @OCA-git-bot @pedrobaeza @carlos-lopez-tecnativa