Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][IMP] l10n_es_aeat_sii_oca: Add Enable SII to journals to enable compatibilities (hr_expense for example) #3827

Merged
merged 1 commit into from
Nov 27, 2024
Merged

[15.0][IMP] l10n_es_aeat_sii_oca: Add Enable SII to journals to enable compatibilities (hr_expense for example) #3827

merged 1 commit into from
Nov 27, 2024

Conversation

victoralmau
Copy link
Member

Backport from 16.0: #3824

Add Enable SII to journals to enable compatibilities (hr_expense for example)

Steps to reproduce:

  • Install hr_expense
  • Create a purchase type journal named Expenses and uncheck the Enable SII field.
  • Go to Expense > Configuration > Settings and define in Employee Expense Journal the Expenses journal previously created
  • Create an expense and an expense sheet
  • Click on the Submit to manager button
  • Click on the Approve button
  • Click on the Post journal entries button
  • The journal entry will be created correctly without any error

Please @pedrobaeza can you review it?

@Tecnativa TT51825

@victoralmau
[IMP] l10n_es_aeat_sii_oca: Add Enable SII to journals to enable comp…
ca2f007 
…atibilities (hr_expense for example)

Steps to reproduce:
- Install hr_expense
- Create a purchase type journal named Expenses and uncheck the Enable SII field.
- Go to Expense > Configuration > Settings and define in Employee Expense Journal the
Expenses journal previously created
- Create an expense and an expense sheet
- Click on the Submit to manager button
- Click on the Approve button
- Click on the Post journal entries button
- The journal entry will be created correctly without any error

TT51825
@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 15.0 milestone Nov 27, 2024
pedrobaeza
pedrobaeza approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport correcto. Una característica para granular más el envío que viene bien.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-3827-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fa801b3 into OCA:15.0 Nov 27, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at dcda7c0. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-imp-l10n_es_aeat_sii_oca-TT51825 branch November 27, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@victoralmau @OCA-git-bot @pedrobaeza