Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][RFC] l10n_br_cte_spec: rename model spec_models to spec_mixin and multi-schema refactor #3467

Draft
wants to merge 3 commits into
base: 14.0
Choose a base branch
from
Draft

[14.0][RFC] l10n_br_cte_spec: rename model spec_models to spec_mixin and multi-schema refactor #3467

wants to merge 3 commits into from

Conversation

marcelsavegnago
Copy link
Member

@marcelsavegnago marcelsavegnago commented Oct 28, 2024 •
edited
Loading

Além do rename estou incluindo nesta PR as modificações para que o modulo fique de acordo com o novo formato do spec_driven_model

@OCA-git-bot
Copy link
Contributor

Hi @rvalyi,
some modules you are maintaining are being modified, check this out!

@marcelsavegnago marcelsavegnago marked this pull request as draft October 28, 2024 11:58
@marcelsavegnago marcelsavegnago force-pushed the 14.0-rfc-l10n_br_cte_spec branch 2 times, most recently from b3a033b to f543dbb Compare October 28, 2024 12:31
@marcelsavegnago
Copy link
Member Author

marcelsavegnago commented Oct 28, 2024 •
edited
Loading

Após ajustes para se adequar as mudanças do spec_driven_model

image

@marcelsavegnago
Copy link
Member Author

marcelsavegnago commented Oct 28, 2024 •
edited
Loading

o problema está aqui

image

este tcte_ antes do _ide e outros campos como como emitente, destinatario e afins

image
Pelo que vi, não acha o comodel e ai vai embora :D

@marcelsavegnago
Copy link
Member Author

diferente no caso do mdfe

image

image

@marcelsavegnago
Copy link
Member Author

No caso do CTE tive que fazer pequenas modificações para que o cte fosse importado corretamente. Campos como name no metadata diferente do nome de fato e campos como o cte40.ide que na verdade é cte40.tcte_ide

bbec281

@marcelsavegnago marcelsavegnago changed the title [14.0][RFC] l10n_br_cte_spec: rename model spec_models to spec_mixin [14.0][RFC] l10n_br_cte_spec: rename model spec_models to spec_mixin and refactor for multi-schema Oct 28, 2024
@marcelsavegnago marcelsavegnago changed the title [14.0][RFC] l10n_br_cte_spec: rename model spec_models to spec_mixin and refactor for multi-schema [14.0][RFC] l10n_br_cte_spec: rename model spec_models to spec_mixin and multi-schema refactor Oct 28, 2024
@marcelsavegnago marcelsavegnago marked this pull request as ready for review October 28, 2024 15:57
rvalyi
rvalyi approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

já que ninguém ainda usa em prod, da para entrar assim e depois iremos ver até onde vc chega com o l10n_br_cte. Talvez ira precisar de algum fix na geração pelo xsdata-odoo para lidar com o "polimrofismo" do CTe, além do que eu tive que fazer já. Veremos.

@mileo
Copy link
Member

mileo commented Oct 30, 2024

Bora fazer o merge?

@marcelsavegnago marcelsavegnago marked this pull request as draft October 31, 2024 12:10
@marcelsavegnago
Copy link
Member Author

marcelsavegnago commented Oct 31, 2024 •
edited
Loading

@mileo ainda nao... vamos ter mais alterações

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaynnan kaynnan kaynnan approved these changes

@mileo mileo mileo approved these changes

@antoniospneto antoniospneto antoniospneto approved these changes

@rvalyi rvalyi rvalyi approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marcelsavegnago @OCA-git-bot @mileo @rvalyi @antoniospneto @kaynnan