Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] crm_location: Migration to 17.0 #583

Merged
merged 18 commits into from
Nov 18, 2024
Merged

[17.0][MIG] crm_location: Migration to 17.0 #583

merged 18 commits into from
Nov 18, 2024

Conversation

ppyczko
Copy link

@ppyczko ppyczko commented Jul 19, 2024

No description provided.

@ppyczko ppyczko mentioned this pull request Jul 19, 2024
Open
20 tasks
@rousseldenis
Copy link

/ocabot migration crm_location

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 19, 2024
@rousseldenis
Copy link

@ppyczko Thanks for this. Could you follow migration guide ? https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#how-to

@ppyczko ppyczko force-pushed the 17.0-mig-crm_location branch 2 times, most recently from 0b626b3 to 150b54c Compare July 19, 2024 08:27
@ppyczko
Copy link
Author

ppyczko commented Jul 19, 2024

Module migrated to version 17.0

cc https://github.com/APSL 158371

@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @BernatObrador please review

Issue #525

peluko00
peluko00 approved these changes Jul 19, 2024
View reviewed changes
Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

BernatObrador
BernatObrador approved these changes Jul 19, 2024
View reviewed changes
Copy link

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code review and tested in runboat

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

antespi and others added 16 commits November 6, 2024 07:33
@antespi @ppyczko
[FIX] Rename crm_case inherited views
9b6c92f
@luismontalba @ppyczko
[MIG] crm_location: Migrated to 10.0
13a9c0d
@primes2h @ppyczko
Translated using Weblate (Italian)
1c57dcb 
Currently translated at 100.0% (4 of 4 strings)

Translation: crm-10.0/crm-10.0-crm_location
Translate-URL: https://translation.odoo-community.org/projects/crm-10-0/crm-10-0-crm_location/it/
@Tardo @ppyczko
[MIG] crm_location: Migration to 12.0
35316c0
@ppyczko
Translated using Weblate (Portuguese (Brazil))
b296730 
Currently translated at 100.0% (4 of 4 strings)

Translation: crm-12.0/crm-12.0-crm_location
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_location/pt_BR/
@CarlesAntoli @ppyczko
Translated using Weblate (Catalan)
04c93b6 
Currently translated at 100.0% (4 of 4 strings)

Translation: crm-12.0/crm-12.0-crm_location
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_location/ca/
@newtratip @ppyczko
[13.0][IMP] crm_location: black, isort
ecf8e4a
@newtratip @ppyczko
[13.0][MIG] crm_location
3c70afb
@skeller1 @ppyczko
[FIX] Clean up license links
302f8c4
@redapureskill @ppyczko
[MIG] crm_location: Migration to 14.0
85d596d
@bizzappdev @ppyczko
[MIG]crm_location: Migrate crm_location to v15.
5c9a62f
@jesusVMayor @ppyczko
[MIG] crm_location: Migration to 16.0
184a972
@ossimantylahti @ppyczko
Translated using Weblate (Finnish)
9987f16 
Currently translated at 100.0% (4 of 4 strings)

Translation: crm-16.0/crm-16.0-crm_location
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_location/fi/
@francesco-ooops @ppyczko
Translated using Weblate (Italian)
43ba3b5 
Currently translated at 100.0% (4 of 4 strings)

Translation: crm-16.0/crm-16.0-crm_location
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_location/it/
@hildickethan @ppyczko
[FIX] crm_location: make computes multi-record aware
a7e9bbf
@ppyczko
[IMP] crm_location: pre-commit auto fixes
af9143a
@ppyczko
Copy link
Author

ppyczko commented Nov 6, 2024

@ppyczko Thanks for this. Could you follow migration guide ? https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#how-to

Hi @rousseldenis, is this ready to merge? Thanks!

victoralmau
victoralmau approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK

crm_location/tests/test_crm_location.py Outdated Show resolved Hide resolved
marcelsavegnago
marcelsavegnago approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-583-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8881f3b into OCA:17.0 Nov 18, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9f74580. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

@BernatObrador BernatObrador BernatObrador approved these changes

@peluko00 peluko00 peluko00 approved these changes

@victoralmau victoralmau victoralmau approved these changes

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.