Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][BKP] component: misc improvements #487

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

simahawk
Copy link
Contributor

@simahawk simahawk commented Sep 2, 2024

Sounds valueable to have a specific type of error
rather than a KeyError when something break
because no registry is ready.

Backport #463

@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@simahawk simahawk changed the title [14.0][BKP] component: add RegistryNotReadyError [14.0][BKP] component: misc improvements Sep 2, 2024
@simahawk
Copy link
Contributor Author

simahawk commented Sep 3, 2024

Waiting for #488

Sounds valueable to have a specific type of error
rather than a KeyError when something break
because no registry is ready.
Handy function to allow depending modules to check for registry readyness
w/o exposing internals.
Contributing and maitaining since a while... ;)
@simahawk
Copy link
Contributor Author

simahawk commented Sep 3, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-487-by-simahawk-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6e178cb into OCA:14.0 Sep 3, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 389db3b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants