Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] connector_base_product: Migration to 17.0 #479

Merged
merged 31 commits into from
Jul 28, 2024

Conversation

john-herholz-dt
Copy link

Simple migration.

  • removed XML declaration from index.html as it is deprecated
  • changed invisible="1" to invisible="True" to reflect View-Pocalypse

bealdav and others added 30 commits December 21, 2023 10:01
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 21, 2024
@john-herholz-dt
Copy link
Author

This PR is still active and ready to get merged. Can someone review and merge it?
Thank you

@dreispt dreispt added needs review and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Apr 27, 2024
Copy link

@bizzappdev bizzappdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@john-herholz-dt
Copy link
Author

john-herholz-dt commented Jul 14, 2024

@pedrobaeza Can you merge this, please?

@pedrobaeza
Copy link
Member

Merging blindly due to reviews:

/ocabot migration connector_base_product
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 14, 2024
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-479-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 14, 2024
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-479-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

@sbidoul I'm finding this error across all 17.0 repos:

psycopg2.errors.UndefinedObject: operator class "gin_trgm_ops" does not exist for access method "gin"

Do you know what it is?

@john-herholz-dt
Copy link
Author

@pedrobaeza can you run the merge command again? The issue with gin should be resolved now.
Thank you!

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-479-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 55209f5 into OCA:17.0 Jul 28, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d966e0a. Thanks a lot for contributing to OCA. ❤️

@john-herholz-dt john-herholz-dt deleted the 17.0-mig-connector_base_product branch October 17, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.