Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0] [MIG] commission: Migration to 18.0 #577

Open
wants to merge 85 commits into
base: 18.0
Choose a base branch
from

Conversation

moaadbourhim
Copy link

No description provided.

AungKoKoLin1997 and others added 30 commits November 12, 2024 22:23
- Make specific top-level menu and permissions for commissions.
- Don't depend on account.
- Reorganize elements.
- Change some parts of the code to fit better ORM tools.
- Adjust permissions in children modules.
- Add <sheet> to some form views to get modern view.
This way, we can restrict which commissions we can select or be
automatically populate in the different documents.
Currently translated at 53.7% (57 of 106 strings)

Translation: commission-15.0/commission-15.0-commission
Translate-URL: https://translation.odoo-community.org/projects/commission-15-0/commission-15-0-commission/ja/
Currently translated at 61.3% (65 of 106 strings)

Translation: commission-15.0/commission-15.0-commission
Translate-URL: https://translation.odoo-community.org/projects/commission-15-0/commission-15-0-commission/ja/
Currently translated at 100.0% (106 of 106 strings)

Translation: commission-15.0/commission-15.0-commission
Translate-URL: https://translation.odoo-community.org/projects/commission-15-0/commission-15-0-commission/ja/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: commission-16.0/commission-16.0-commission
Translate-URL: https://translation.odoo-community.org/projects/commission-16-0/commission-16-0-commission/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: commission-16.0/commission-16.0-commission
Translate-URL: https://translation.odoo-community.org/projects/commission-16-0/commission-16-0-commission/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: commission-16.0/commission-16.0-commission
Translate-URL: https://translation.odoo-community.org/projects/commission-16-0/commission-16-0-commission/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: commission-16.0/commission-16.0-commission
Translate-URL: https://translation.odoo-community.org/projects/commission-16-0/commission-16-0-commission/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: commission-16.0/commission-16.0-commission
Translate-URL: https://translation.odoo-community.org/projects/commission-16-0/commission-16-0-commission/
OCA-git-bot and others added 20 commits November 12, 2024 22:23
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: commission-17.0/commission-17.0-commission
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission/
Currently translated at 100.0% (135 of 135 strings)

Translation: commission-17.0/commission-17.0-commission
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: commission-17.0/commission-17.0-commission
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission/
Currently translated at 100.0% (137 of 137 strings)

Translation: commission-17.0/commission-17.0-commission
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: commission-17.0/commission-17.0-commission
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: commission-17.0/commission-17.0-commission
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission/
Currently translated at 94.8% (130 of 137 strings)

Translation: commission-17.0/commission-17.0-commission
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission/pt/
Currently translated at 94.8% (130 of 137 strings)

Translation: commission-17.0/commission-17.0-commission
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission/pt/
Currently translated at 100.0% (137 of 137 strings)

Translation: commission-17.0/commission-17.0-commission
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission/pt/
Currently translated at 100.0% (137 of 137 strings)

Translation: commission-17.0/commission-17.0-commission
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: commission-17.0/commission-17.0-commission
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission/
Currently translated at 94.1% (128 of 136 strings)

Translation: commission-17.0/commission-17.0-commission
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission/tr/
@moaadbourhim moaadbourhim mentioned this pull request Nov 12, 2024
6 tasks
@moaadbourhim
Copy link
Author

/ocabot migration commission

@OCA-git-bot
Copy link
Contributor

Sorry @moaadbourhim you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@pedrobaeza
Copy link
Member

Hi @moaadbourhim there are changes that shouldn't belong to [IMP] commission: pre-commit auto fixes. In fact, there shouldn't be any, as pre-commit shouldn't trigger anything before changing the version (and you mustn't change the manifest version yet). There are also some indentation changes that aren't correct.

/ocabot migration commission

Once corrected, you have to find reviewers:

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review

You can review other PRs, and ask in exchange that they review yours.

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Nov 13, 2024
@moaadbourhim
Copy link
Author

Hi @pedrobaeza

I have reviewed the link you shared and addressed the points mentioned. For the indentation issues, I used pre-commit to fix all the indentation problems.

Please let me know if anything else needs to be adjusted.

Thanks!

@pedrobaeza
Copy link
Member

It seems there's still the same issues I commented before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.