[16.0][FIX] account_avatax_oca, skip exception raise on lines with not product in display_type #404
Conversation
|
Hi @dreispt, |
ChrisOForgeFlow
force-pushed
the
16.0-fix-compute_all_exception
branch
3 times, most recently
from
a1592a9
to
43ccfee
Compare
BernatPForgeFlow
force-pushed
the
16.0-fix-compute_all_exception
branch
from
43ccfee
to
302c0b6
Compare
| and float_compare(line.quantity, quantity, digits) == 0 | ||
| ): | ||
| avatax_amount = copysign(line.avatax_amt_line, base) | ||
| break |
There was a problem hiding this comment.
A lot of logic changes here that I don't understand , I'm not comfortable with this.
There was a problem hiding this comment.
This change is only for adding a process of current aml, if that is not found, should be done standard behavior, you can notice change in showed only for tab adding in else condition
|
|
||
| if not hasattr(AccountMoveLine, "_compute_all_tax_origin"): | ||
| AccountMoveLine._compute_all_tax_origin = AccountMoveLine._compute_all_tax | ||
| AccountMoveLine._compute_all_tax = _compute_all_tax_new |
There was a problem hiding this comment.
It looks like we are monkey patching the _compute_all_tax method.
Why would we need to do that?
There was a problem hiding this comment.
It's needed because in this line https://github.com/odoo/odoo/blob/16.0/addons/account/models/account_move_line.py#L940, I'm adding a context with current aml, to know what account move line trigger tax compute, then in next process I can process with more precision
AlexPForgeFlow
force-pushed
the
16.0-fix-compute_all_exception
branch
from
558efde
to
b1ad441
Compare
AlexPForgeFlow
force-pushed
the
16.0-fix-compute_all_exception
branch
from
8c82350
to
46cc26a
Compare
…t product in display_type
ChrisOForgeFlow
force-pushed
the
16.0-fix-compute_all_exception
branch
from
46cc26a
to
34336f0
Compare
@ForgeFlow