Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.flask-mail: disable broken tests #349408

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

jackwilsdon
Copy link
Contributor

These tests are broken by the fix for CVE-2023-27043 in the built-in email package, released in Python 3.9.20 / 3.10.15 / 3.11.10 / 3.12.6 / 3.13.0.

I've opened pallets-eco/flask-mail#233 upstream for this.

Fixes #349350.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jackwilsdon
Copy link
Contributor Author

Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:
  • powerdns-admin
8 packages built:
  • pgadmin4
  • pgadmin4-desktopmode
  • pgadmin4-desktopmode.dist
  • pgadmin4.dist
  • python311Packages.flask-mail
  • python311Packages.flask-mail.dist
  • python312Packages.flask-mail
  • python312Packages.flask-mail.dist

The powerdns-admin build failure looks unrelated:

Error: While importing 'powerdnsadmin', an ImportError was raised:

Traceback (most recent call last):
  File "/nix/store/jwnh6qhxjys48v8xnjg10fzh5i6dqk6s-python3.12-flask-3.0.3/lib/python3.12/site-packages/flask/cli.py", l>
    __import__(module_name)
  File "/build/source/powerdnsadmin/__init__.py", line 7, in <module>
    from .lib import utils
  File "/build/source/powerdnsadmin/lib/utils.py", line 9, in <module>
    from distutils.version import StrictVersion
ModuleNotFoundError: No module named 'distutils'

@Atemu
Copy link
Member

Atemu commented Oct 18, 2024

I've opened pallets-eco/flask-mail#233 upstream for this.

Could you add that as a comment so that future maintainers can verify whether this still holds?

@jackwilsdon
Copy link
Contributor Author

Done 👍

Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, if ofBorg passes we're GTG.

@gador
Copy link
Member

gador commented Oct 18, 2024

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

nixpkgs-review result

✅ 8 packages built:
  • pgadmin4
  • pgadmin4-desktopmode
  • pgadmin4-desktopmode.dist
  • pgadmin4.dist
  • python311Packages.flask-mail
  • python311Packages.flask-mail.dist
  • python312Packages.flask-mail
  • python312Packages.flask-mail.dist

@gador
Copy link
Member

gador commented Oct 18, 2024

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

nixpkgs-review result

1 package failed to build and are new build failure:
  • powerdns-admin: log was empty
✅ 8 packages built:
  • pgadmin4
  • pgadmin4-desktopmode
  • pgadmin4-desktopmode.dist
  • pgadmin4.dist
  • python311Packages.flask-mail
  • python311Packages.flask-mail.dist
  • python312Packages.flask-mail
  • python312Packages.flask-mail.dist

@gador gador merged commit ccc0c21 into NixOS:master Oct 18, 2024
10 of 11 checks passed
@jackwilsdon jackwilsdon deleted the fix-flask-mail branch October 18, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build failure: python3Packages.flaks-mail
4 participants