-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.flask-mail: disable broken tests #349408
Conversation
Result of 1 package failed to build:
8 packages built:
The
|
Could you add that as a comment so that future maintainers can verify whether this still holds? |
33999c9
to
769b2af
Compare
Done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM, if ofBorg passes we're GTG.
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
|
769b2af
to
cdfb779
Compare
These tests are broken by the fix for CVE-2023-27043 in the built-in
email
package, released in Python 3.9.20 / 3.10.15 / 3.11.10 / 3.12.6 / 3.13.0.I've opened pallets-eco/flask-mail#233 upstream for this.
Fixes #349350.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.