python3Packages.typer: disable failing tests on darwin #145393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these all seem to stem from the shellingham package being unable to detect the shell (even if we provide `ps` to it), likely related to a known issue
risicle
force-pushed
the
ris-typer-darwin-fix
branch
from
5a6aa3b
to
d2fc99d
Compare
|
@ofborg build python38Packages.typer python39Packages.typer |
|
cc @NixOS/darwin-maintainers |
uri-canva
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
ZHF: #144627
These all seem to stem from the
shellinghampackage being unable to detect the shell (even if we providepsto it), likely related to a known issue sarugaku/shellingham#35Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)